do not use stream to check file downloads #32703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
force-pushed
the
doNotUseStreamDownload
branch
from
e34b81b
to
d015f15
Compare
phil-davis
approved these changes
Sep 14, 2018
|
backport in #32704 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
after #32594 we do user
streamandtimeoutoption together for guzzle, sometimes they don't work together and we receiveGuzzleHttp\Ring\Exception\RingExceptionThis specially happens with LDAP and encryption testing
I don't think we need the stream upload here in the first place
Even the change of #32594 is not yet in master we want to have the change here also
How Has This Been Tested?
run failing tests in stable10 with the changes
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: