Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat all email addresses that had sending problems #32632

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 7, 2018

Description

Implode all the failed email address results, not just the last one.

Related Issue

#31845

Motivation and Context

#32506 changes the email sending when creating public links so that it sends an individual email to each recipient, instead of a bulk email with the recipients as Bcc.

After that change, issue #31845 is back, in that it only reports the last recipient email that could not be sent. It should report all the email addresses that could be not sent. That issue was fixed earlier by PR #31847

How Has This Been Tested?

Manually in the UI, following steps like in PR #31847

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Copy link
Contributor

@davitol davitol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@phil-davis
Copy link
Contributor Author

Backport stable10 #32633

@phil-davis
Copy link
Contributor Author

Note: the code touched here is at a level above the method(s) that are unit tested. And so far there are no webUI acceptance tests at this level of detail for public link sharing.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 7c1b712 into master Sep 7, 2018
@PVince81 PVince81 deleted the email-reporting-sharing branch September 7, 2018 10:34
@lock lock bot locked as resolved and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants