Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] move getPageTitle() to pageObject #32631

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

individual-it
Copy link
Member

backport of #32630

@individual-it individual-it force-pushed the stable10-moveGetTitleToPageObject branch from f8dcd5f to bcd3cba Compare September 7, 2018 10:16
@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #32631 into stable10 will increase coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #32631      +/-   ##
==============================================
+ Coverage       62.46%   62.92%   +0.46%     
  Complexity      18853    18853              
==============================================
  Files            1235     1235              
  Lines           73909    73911       +2     
  Branches         1282     1282              
==============================================
+ Hits            46165    46511     +346     
+ Misses          27364    27020     -344     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.16% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.98% <ø> (+0.51%) 18853 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair/SqliteAutoincrement.php 85.18% <0%> (-3.28%) 9% <0%> (ø)
lib/private/DB/AdapterSqlite.php 83.33% <0%> (-2.88%) 7% <0%> (ø)
lib/private/Share/Share.php 67.03% <0%> (+0.06%) 502% <0%> (ø) ⬇️
apps/dav/lib/CalDAV/CalDavBackend.php 80.6% <0%> (+0.13%) 173% <0%> (ø) ⬇️
apps/dav/lib/CardDAV/CardDavBackend.php 83.21% <0%> (+0.23%) 80% <0%> (ø) ⬇️
lib/private/Files/View.php 84.37% <0%> (+0.3%) 380% <0%> (ø) ⬇️
lib/private/legacy/util.php 69.52% <0%> (+1.02%) 220% <0%> (ø) ⬇️
lib/private/legacy/db.php 71.79% <0%> (+1.28%) 33% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+1.44%) 68% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.56% <0%> (+1.82%) 105% <0%> (ø) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080c279...bcd3cba. Read the comment docs.

@PVince81 PVince81 merged commit be93d3c into stable10 Sep 7, 2018
@PVince81 PVince81 deleted the stable10-moveGetTitleToPageObject branch September 7, 2018 10:59
@PVince81 PVince81 modified the milestones: development, QA Jan 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants