Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] use samaccountname from session for wnd login #32579

Closed

Conversation

butonic
Copy link
Member

@butonic butonic commented Sep 4, 2018

backport of #31951

Rename "samaccountname" to "altloginname" and add tests

store username as preference, allow sync from backend

fix tests

add tests

fix tests
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2018

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2018

Gitmate is stuck rebasing 😱

I've made a new branch just to be sure... here #32587

@PVince81 PVince81 closed this Sep 5, 2018
@PVince81 PVince81 deleted the stable10-bugfix/samaccountname-as-wnd-username branch September 5, 2018 08:25
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants