[objectstore] Fix checksums not being updated on modifying shared file #32337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32337 +/- ##
============================================
+ Coverage 64.01% 64.01% +<.01%
- Complexity 18564 18567 +3
============================================
Files 1171 1171
Lines 69851 69861 +10
Branches 1267 1267
============================================
+ Hits 44714 44722 +8
- Misses 24767 24769 +2
Partials 370 370
Continue to review full report at Codecov.
|
mrow4a
force-pushed
the
obj_fix_checks_shared
branch
from
f69a21a
to
7124102
Compare
mrow4a
force-pushed
the
obj_fix_checks_shared
branch
from
7124102
to
a038741
Compare
mrow4a
commented
Aug 16, 2018
| public function scanFile($file, $reuseExisting = 0, $parentId = -1, $cacheData = null, $lock = true) { | ||
| $sourceScanner = $this->getSourceScanner(); | ||
| if ($sourceScanner instanceof NoopScanner) { | ||
| return []; | ||
| list(, $internalPath) = $this->storage->resolvePath($file); | ||
| return parent::scan($internalPath, $reuseExisting, $parentId, $cacheData, $lock); |
There was a problem hiding this comment.
@DeepDiver1975 @PVince81 this is an easy fix for the issue.. but I think this class needs larger refactoring to make it support both local filesystem and objectstorage..
|
Looks good. Lets merge this to master and See ..... |
DeepDiver1975
approved these changes
Aug 16, 2018
|
Looks good - see comment on PR with test scenarios #32353 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Failing smashbox tests with sharing on objectstore.
Solution
SharingScanner did not update checksums in file cache for object store, since logic for obcjectstorage has not been implemented (SharingScanner assumes by default Local Filesystem). This PR adds logic for objectstorage.
@DeepDiver1975 @patrickjahns