-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store schedule-calendar-transp as integer in the database #32011
Conversation
@DeepDiver1975 question: this adds a test, but does it also fix the issue? according what nc did (pls follow their thread) they changed the following: https://github.com/owncloud/core/blob/master/apps/dav/lib/CalDAV/CalDavBackend.php#L558
https://github.com/owncloud/core/blob/master/apps/dav/lib/CalDAV/CalDavBackend.php#L602
|
CI fail of https://drone.owncloud.com/owncloud/core/8514/355 webUIPersonalSetttings is due to #32012 |
@mmattel I first only pushed the test as I want to see it fail. I could not reproduce the issue locally - let's see if drone can ... |
Fine to me. Just written my comments as you wrote |
thats why the label is '2 - Developing' - don't look at PR with that label ;-) |
f2d661a
to
6b877ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #32011 +/- ##
============================================
+ Coverage 63.58% 63.59% +<.01%
- Complexity 18553 18556 +3
============================================
Files 1169 1169
Lines 69604 69604
Branches 1264 1264
============================================
+ Hits 44260 44263 +3
+ Misses 24975 24972 -3
Partials 369 369
Continue to review full report at Codecov.
|
My star sign is virgin and they are known to go into the details 😄 |
6b877ab
to
a4cbb62
Compare
@ownclouders rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
… 'schedule-calendar-transp'
Automated rebase with GitMate.io was successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport |
Description
Make sure to insert correct data into the database
Related Issue
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: