Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store schedule-calendar-transp as integer in the database #32011

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

DeepDiver1975
Copy link
Member

Description

Make sure to insert correct data into the database

Related Issue

How Has This Been Tested?

  • adding unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@mmattel
Copy link
Contributor

mmattel commented Jul 9, 2018

@DeepDiver1975 question: this adds a test, but does it also fix the issue? according what nc did (pls follow their thread) they changed the following:

https://github.com/owncloud/core/blob/master/apps/dav/lib/CalDAV/CalDavBackend.php#L558

-	$values['transparent'] = $properties[$transp]->getValue()==='transparent';
+	$values['transparent'] = (int) ($properties[$transp]->getValue() === 'transparent');

https://github.com/owncloud/core/blob/master/apps/dav/lib/CalDAV/CalDavBackend.php#L602

-	$newValues[$fieldName] = $propertyValue->getValue() === 'transparent';
+	$newValues[$fieldName] = (int) ($propertyValue->getValue() === 'transparent');

@phil-davis
Copy link
Contributor

CI fail of https://drone.owncloud.com/owncloud/core/8514/355 webUIPersonalSetttings is due to #32012

@DeepDiver1975
Copy link
Member Author

@mmattel I first only pushed the test as I want to see it fail. I could not reproduce the issue locally - let's see if drone can ...

@mmattel
Copy link
Contributor

mmattel commented Jul 9, 2018

I first only pushed the test as I want to see it fail

Fine to me. Just written my comments as you wrote Fixes #32007

@DeepDiver1975
Copy link
Member Author

Fine to me. Just written my comments as you wrote Fixes #32007
Merge state

thats why the label is '2 - Developing' - don't look at PR with that label ;-)

@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #32011 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #32011      +/-   ##
============================================
+ Coverage     63.58%   63.59%   +<.01%     
- Complexity    18553    18556       +3     
============================================
  Files          1169     1169              
  Lines         69604    69604              
  Branches       1264     1264              
============================================
+ Hits          44260    44263       +3     
+ Misses        24975    24972       -3     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.59% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.85% <100%> (ø) 18556 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php 80.65% <100%> (+0.54%) 179 <0> (+3) ⬆️
lib/private/Helper/LocaleHelper.php 97.36% <0%> (-2.64%) 15% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6303095...aaee903. Read the comment docs.

@mmattel
Copy link
Contributor

mmattel commented Jul 9, 2018

My star sign is virgin and they are known to go into the details 😄
"Fixes" is for virgins differnt to "adresses" - and virgins cant let that stay uncommented 😄

@DeepDiver1975 DeepDiver1975 changed the title Test schedule-calendar-transp Store schedule-calendar-transp as integer in the database Jul 9, 2018
@DeepDiver1975
Copy link
Member Author

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
Copy link
Contributor

Backport stable10 #32024

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding calendar or reminder via CalDAV on macOS results in SQL error
4 participants