birthday calendar exposes no access share state and is…

[DeepDiver1975]

… then not selected for attendee scheduling

Description

For local delivery of scheduling of calendar objects always the first calendar is chosen for a user.
In some cases this is the birthday calendar which is bad because the user cannot edit event in there.

In order to solve this the birthday calendar exposes the {DAV:}share-access property with the value NOACCESS which indicates that the user has no access. The next calendar will be chosen.

This is a bit hacky but acceptable because we are not using this property in any other case.

Related Issue

fixes #26746

How Has This Been Tested?

• manual testing of adding a local user to an event. this user has only the birthday calendar

more testing is necessary to make sure that there is no impact on sharing of calendars.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #31833 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #31833      +/-   ##
============================================
+ Coverage     63.27%   63.28%   +0.01%     
- Complexity    18479    18486       +7     
============================================
  Files          1161     1161              
  Lines         69377    69396      +19     
  Branches       1261     1261              
============================================
+ Hits          43895    43917      +22     
+ Misses        25112    25109       -3     
  Partials        370      370

Flag	Coverage Δ	Complexity Δ
#javascript	52.47% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.52% <100%> (+0.01%)	18486 <5> (+7)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/CalDAV/Calendar.php	85.84% <100%> (+0.54%)	44 <0> (+2)	⬆️
apps/dav/lib/CalDAV/Plugin.php	92.3% <100%> (+92.3%)	7 <5> (+5)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a526d4...b44bde0. Read the comment docs.

[cdamken]

👍 Tested and works fine

[DeepDiver1975]

Test Steps

• create user A with email address a@example.net
• create user B with email address b@example.net
• make sure user B has a birthday calendar (create a contact via the contacts app who has a birthday)
• login as user B and delete all calendars with exception of the birthday calendar
• login as user A and create a new event and add b@example.net as attendee
• with this patch in place the event will NOT be added to the birthday calendar of user B