Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw an error when the same theme enabled twice #31771

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jun 13, 2018

Description

I shouldn't get a serious exception when I enable an app a 2nd time. Other apps doesn't have this problem

TL;DR
#31475

Related Issue

Fixes #31475

Motivation and Context

#31475 (comment)

How Has This Been Tested?

enabling the same the twice with no error:

deo@jah-mobile:> php occ app:enable theme-example
theme-example enabled
deo@jah-mobile:> php occ app:enable theme-example
theme-example enabled

enabling a different theme (exception is expected in this case):

> php occ app:enable theme-hey

In AppManager.php line 260:
                                                               
  theme-hey can't be enabled until theme-example is disabled.  
                                                               

app:enable [-g|--groups GROUPS] [--] <app-id>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the development milestone Jun 13, 2018
@VicDeo VicDeo self-assigned this Jun 13, 2018
@VicDeo VicDeo changed the title Allow enable the same theme twice Do not throw an error when the same theme enabled twice Jun 13, 2018
@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #31771 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31771      +/-   ##
============================================
+ Coverage     63.17%   63.17%   +<.01%     
- Complexity    18448    18449       +1     
============================================
  Files          1158     1158              
  Lines         69294    69296       +2     
  Branches       1261     1261              
============================================
+ Hits          43776    43778       +2     
  Misses        25148    25148              
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.47% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.4% <100%> (ø) 18449 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/App/AppManager.php 86.04% <100%> (+0.13%) 84 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742d088...8c36bc9. Read the comment docs.

@PVince81 PVince81 merged commit a1f0493 into master Jun 14, 2018
@PVince81 PVince81 deleted the fix-31475 branch June 14, 2018 09:07
@PVince81
Copy link
Contributor

@VicDeo please backport for after 10.0.9

@VicDeo
Copy link
Member Author

VicDeo commented Jun 14, 2018

Stable10: #31783

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OCP\App\AppManagerException] when I run occ app:enable theme-* twice
4 participants