Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip tests for issue 29599 #31724

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Unskip tests for issue 29599 #31724

merged 1 commit into from
Nov 2, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 12, 2018

since it should be fixed by "Update sabre/dav to 3.3.0-alpha1"

Just testing here to see if the tests pass. Then I can refactor them into the relevant scenario outlines... and put the final/proper commit in with PR #31644

Related issue #29599

@phil-davis
Copy link
Contributor Author

The unskipped tests are passing, which is good.

@phil-davis
Copy link
Contributor Author

phil-davis commented Jul 31, 2018

This can sit here until the parent PR moves forward.

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #31724 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31724   +/-   ##
=========================================
  Coverage     64.06%   64.06%           
  Complexity    18277    18277           
=========================================
  Files          1190     1190           
  Lines         69051    69051           
  Branches       1271     1271           
=========================================
  Hits          44238    44238           
  Misses        24443    24443           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (ø) 18277 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c6ff6b...c2e32ca. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Rebased underlying PR which still has the failing test - see comment #31644 (comment)

That is the only fail here. So the unskipped tests are passing - good.

@individual-it
Copy link
Member

that should be fixed by now @phil-davis can you rebase?

@phil-davis phil-davis force-pushed the unskip-issue-29599-2 branch 2 times, most recently from b96817e to b798b5c Compare November 1, 2018 10:28
@phil-davis
Copy link
Contributor Author

Rebased. This should pass against current master now. Let's see.

@phil-davis
Copy link
Contributor Author

@paurakhsharma @individual-it this is ready for review

@phil-davis
Copy link
Contributor Author

Backport stable10 #33402

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 codecov is not coming, I am tired of rebasing this to make CI cooperate.
Please review and force merge.

@PVince81 PVince81 merged commit 0aacf9e into master Nov 2, 2018
@PVince81 PVince81 deleted the unskip-issue-29599-2 branch November 2, 2018 14:45
@lock lock bot locked as resolved and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants