-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip tests for issue 29599 #31724
Unskip tests for issue 29599 #31724
Conversation
The unskipped tests are passing, which is good. |
|
e83b1cb
to
6847763
Compare
Codecov Report
@@ Coverage Diff @@
## master #31724 +/- ##
=========================================
Coverage 64.06% 64.06%
Complexity 18277 18277
=========================================
Files 1190 1190
Lines 69051 69051
Branches 1271 1271
=========================================
Hits 44238 44238
Misses 24443 24443
Partials 370 370
Continue to review full report at Codecov.
|
Rebased underlying PR which still has the failing test - see comment #31644 (comment) That is the only fail here. So the unskipped tests are passing - good. |
that should be fixed by now @phil-davis can you rebase? |
b96817e
to
b798b5c
Compare
Rebased. This should pass against current master now. Let's see. |
b798b5c
to
c2e32ca
Compare
@paurakhsharma @individual-it this is ready for review |
Backport |
@DeepDiver1975 codecov is not coming, I am tired of rebasing this to make CI cooperate. |
since it should be fixed by "Update sabre/dav to 3.3.0-alpha1"
Just testing here to see if the tests pass. Then I can refactor them into the relevant scenario outlines... and put the final/proper commit in with PR #31644Related issue #29599