Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Use correct expiration variable for link share mail #31209

Merged
merged 2 commits into from
May 14, 2018

Conversation

PVince81
Copy link
Contributor

Master port of #31201

@PVince81 PVince81 added this to the development milestone Apr 19, 2018
@PVince81 PVince81 self-assigned this Apr 19, 2018
@codecov
Copy link

codecov bot commented Apr 19, 2018

Codecov Report

Merging #31209 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31209   +/-   ##
=========================================
  Coverage     62.57%   62.57%           
  Complexity    18234    18234           
=========================================
  Files          1145     1145           
  Lines         68396    68396           
  Branches       1234     1234           
=========================================
  Hits          42799    42799           
  Misses        25236    25236           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.77% <0%> (ø) 18234 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/ajax/share.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2543f6...bd128c1. Read the comment docs.

@PVince81
Copy link
Contributor Author

also added #31212

@DeepDiver1975
Copy link
Member

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

Vincent Petry added 2 commits April 21, 2018 09:57
Use the correct attribute name for expiration date in the
MailNotificationFilter
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@PVince81
Copy link
Contributor Author

@DeepDiver1975 quick review of this port ?

@DeepDiver1975 DeepDiver1975 merged commit a727ce6 into master May 14, 2018
@DeepDiver1975 DeepDiver1975 deleted the share-expiration-email branch May 14, 2018 08:07
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants