Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Respect sharing.federation.allowHttpFallback in FederatedSha… #31197

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

DeepDiver1975
Copy link
Member

…reProvider

frontport #31196

@DeepDiver1975 DeepDiver1975 force-pushed the master-c3c8f67e60c81671bec65907dde654214ee37348 branch from fb439b7 to 7ae5e8e Compare April 19, 2018 10:33
@codecov
Copy link

codecov bot commented Apr 19, 2018

Codecov Report

Merging #31197 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31197      +/-   ##
============================================
- Coverage     62.54%   62.54%   -0.01%     
- Complexity    18263    18264       +1     
============================================
  Files          1146     1146              
  Lines         68443    68451       +8     
  Branches       1234     1234              
============================================
+ Hits          42808    42812       +4     
- Misses        25274    25278       +4     
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.73% <83.33%> (-0.01%) 18264 <0> (+1)
Impacted Files Coverage Δ Complexity Δ
...ederatedfilesharing/lib/BackgroundJob/RetryJob.php 0% <0%> (ø) 10 <0> (ø) ⬇️
lib/private/Share20/ProviderFactory.php 95.08% <100%> (+0.08%) 16 <0> (ø) ⬇️
apps/federatedfilesharing/lib/Notifications.php 48.48% <100%> (+0.06%) 32 <0> (+1) ⬆️
ocs/routes.php 100% <100%> (ø) 0 <0> (ø) ⬇️
...s/federatedfilesharing/lib/AppInfo/Application.php 100% <100%> (ø) 3 <0> (ø) ⬇️
lib/private/Http/Client/Client.php 86% <0%> (-2%) 17% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23eea00...b6982a0. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 05c5435 into master Apr 20, 2018
@PVince81 PVince81 deleted the master-c3c8f67e60c81671bec65907dde654214ee37348 branch April 20, 2018 07:52
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants