Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[stable10] Retry chunks in web UI on stalled uploads" #31185

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

PVince81
Copy link
Contributor

Reverts #31005

This somehow stopped working on 10.0.8 RC2 or I'm really unlucky with testing.

Every upload now shows a message that the chunk sizes do not sum up to the expected value when at least one chunk got retried.

As I have no time to dig deeper, let's revert this on stable10 and investigate for 10.0.9.

As discussed with @pmaier1

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #31185 into stable10 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #31185      +/-   ##
==============================================
+ Coverage       60.22%   60.22%   +<.01%     
  Complexity      18188    18188              
==============================================
  Files            1194     1194              
  Lines           71777    71773       -4     
  Branches         1248     1248              
==============================================
- Hits            43230    43228       -2     
+ Misses          28177    28175       -2     
  Partials          370      370
Flag Coverage Δ Complexity Δ
#javascript 52.64% <ø> (-0.03%) 0 <ø> (ø)
#phpunit 61.06% <0%> (ø) 18188 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/App.php 37.5% <0%> (+12.5%) 3 <0> (ø) ⬇️
core/js/js.js 54.6% <0%> (-0.24%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959efd1...6990530. Read the comment docs.

@PVince81 PVince81 merged commit bd85a24 into stable10 Apr 18, 2018
@PVince81 PVince81 deleted the revert-31005-stable10-retry-on-stalled-upload branch April 18, 2018 13:15
@PVince81 PVince81 mentioned this pull request Apr 18, 2018
29 tasks
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants