Fix error when reading empty authtoken names from db

[IljaN]

Issue: #30792

[patrickjahns]

Not sure if this is the right path to go - we explicitly disallowed empty tokens to be entered in the frontend (which makes sense).

Alternative should rather be to provide a proper migration when upgrading?

[IljaN]

@patrickjahns Were empty names allowed in the version before?

[DeepDiver1975]

Title is missleading

[IljaN]

@DeepDiver1975 better?

[patrickjahns]

@IljaN
in 10.0.4 it was allowed - with #29831 it was discouraged
Issue fixed by disallowing empty tokens:
#29709

Expected behavior changed to requiring a name for the token with 10.0.5

[IljaN]

Alternative should rather be to provide a proper migration when upgrading?

@PVince81 I think @patrickjahns has a point, what do you think?

[PVince81]

Ok for a migration so no code workaround needed.

I just found it weird that we validate the token data even after reading from the DB.

[IljaN]

It`s probably because the DB layer is using same setters when populating objects from db

[IljaN]

Will create a migration then

[patrickjahns]

@IljaN
Exactly - that's what made me triage the bug to 'lets just create a string in the db'
https://github.com/owncloud/core/blob/master/lib/public/AppFramework/Db/Entity.php#L67-L70

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.