Properly use error exit code when php version or platform is not supp…

[DeepDiver1975]

…orted

Description

In case occ cannot be used because the platform (windows) or the php version is wrong we shall exit 1 to indicate the calling script that something went wrong

Related Issue

owncloud/contacts#636 (comment)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[phil-davis]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[codecov]

Codecov Report

Merging #30700 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #30700   +/-   ##
=========================================
  Coverage     61.38%   61.38%           
  Complexity    18347    18347           
=========================================
  Files          1157     1157           
  Lines         68979    68979           
  Branches       1242     1242           
=========================================
  Hits          42340    42340           
  Misses        26267    26267           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	52.33% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	62.4% <0%> (ø)	18347 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
console.php	0% <0%> (ø)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1fb859...57e5c79. Read the comment docs.

[phil-davis]

Somehow the drone UI test runs were using old names for the UI test suites, and could not find them. Not sure how a PR could get out of sync with that. Anyway, a rebase might help.

[DeepDiver1975]

Somehow the drone UI test runs were using old names for the UI test suites, and could not find them. Not sure how a PR could get out of sync with that. Anyway, a rebase might help.

THX - I guess I was simply on an older state on my local master. THX for taking care!

[sharidas]

Wouldn't it be nice to have same exit code for

1. https://github.com/owncloud/core/blob/master/index.php#L35
2. https://github.com/owncloud/core/blob/master/index.php#L42 and
3. https://github.com/owncloud/core/blob/master/index.php#L49
   Sorry, if my observation is wrong.

[DeepDiver1975]

@sharidas index.php is called by the web server - no idea how exit codes will influence the behavior. My change is required for console execution.

THX for caring!

[DeepDiver1975]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[phil-davis]

Backport stable10 #30780

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.