-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow regular users to change their CORS domains #30648
Conversation
15b122e
to
cac7438
Compare
Codecov Report
@@ Coverage Diff @@
## master #30648 +/- ##
=========================================
Coverage 61.9% 61.9%
Complexity 19061 19061
=========================================
Files 1091 1091
Lines 61473 61473
=========================================
Hits 38052 38052
Misses 23421 23421
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - works 👍
stable10: #30649 |
works. But should not the domains then appear in the list of the white-listed domains? |
ah ok, it looks like there is no error showed if you enter an invalid URL (i.e. missing the http part) |
yes, that's another bug... will take a bit more time to fix as there is no way to return an error here... need to port the code to use ajax calls instead of full page request |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
See subject
Related Issue
Fixes #30647
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: