Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Retry upload test runs 02 #30522

Closed
wants to merge 2 commits into from
Closed

Conversation

phil-davis
Copy link
Contributor

Rerun drone upload UI test suite lots of times to verify if changes in #30513 are good.

@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #30522 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30522      +/-   ##
============================================
+ Coverage     61.59%    61.6%   +<.01%     
  Complexity    18505    18505              
============================================
  Files          1090     1090              
  Lines         61104    61104              
============================================
+ Hits          37640    37641       +1     
+ Misses        23464    23463       -1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 98.7% <0%> (+1.29%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5820766...b1079c9. Read the comment docs.

@phil-davis
Copy link
Contributor Author

phil-davis commented Feb 19, 2018

The 1st set of 11 test runs of the upload suite are good - it sometimes gets the "file locked" notification when trying to upload-overwrite lorem.txt and retries the UI-based upload sequence. It always passes the 2nd try.

2nd set of 11 test runs of the upload suite are also good. The "file locked" situation happens a lot - 7/11 times for this set of test runs. So the timing interaction is a common thing. But the 2nd upload attempt always works.

3rd set of test runs is also good. "same" statistical results as the other runs.

@phil-davis
Copy link
Contributor Author

Seems beneficial - closing this testing PR.

@phil-davis phil-davis closed this Feb 19, 2018
@PVince81 PVince81 deleted the retry-upload-test-runs-02 branch September 27, 2018 13:35
@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant