[stable10] Check the return value of getUserSession before using it

[sharidas]

Checking if the value returned by getUserSession
and getUser is null or not before using it.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

There were situations where userSession was directly calling getUser which returned null and the return value was never checked. Another case was getUserSession was returning null. Hence getUser was called on null. This caused breaking the code flow under certain conditions. This change is to fix the assumptions made.

Related Issue

#30335
#30416

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[phil-davis]

This is a backport of PR #30418
(it is good to mention the PR number of the original PR, that makes an easy-to-see link between them)
(oh - I see you mentioned the backport in the main PR already!)

[sharidas]

(it is good to mention the PR number of the original PR, that makes an easy-to-see link between them)

sure.

[PVince81]

👍

[phil-davis]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[phil-davis]

I tried a rebase to trigger CI again. It does nothing because there are no new commits in stable10 so the rebase is a NOOP. Needs a "real rebase" either in a local repo and force push, or make the bot do it after the next thing is merged to stable10

I luv CI ;)

[codecov]

Codecov Report

Merging #30432 into stable10 will increase coverage by <.01%.
The diff coverage is 91.66%.

@@              Coverage Diff               @@
##             stable10   #30432      +/-   ##
==============================================
+ Coverage       61.19%    61.2%   +<.01%     
- Complexity      18088    18092       +4     
==============================================
  Files            1068     1068              
  Lines           60089    60093       +4     
==============================================
+ Hits            36774    36780       +6     
+ Misses          23315    23313       -2

Impacted Files	Coverage Δ	Complexity Δ
lib/private/User/User.php	83.43% <100%> (+0.19%)	66 <0> (+3)	⬆️
lib/private/Log.php	79.51% <83.33%> (+2.97%)	37 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aefb9f7...4d9146a. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.