Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache app path if app is not found #30144

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Do not cache app path if app is not found #30144

merged 1 commit into from
Jan 16, 2018

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jan 15, 2018

Description

Related Issue

Fixes #30112 #30126

Motivation and Context

Fixes

How Has This Been Tested?

  • Unit-test
  • php occ market:install -l ../xmas-0.0.4.tar.gz

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jan 16, 2018

Codecov Report

Merging #30144 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #30144     +/-   ##
===========================================
+ Coverage     57.94%   58.24%   +0.3%     
- Complexity    18525    18526      +1     
===========================================
  Files          1094     1094             
  Lines         63707    63743     +36     
===========================================
+ Hits          36914    37130    +216     
+ Misses        26793    26613    -180
Impacted Files Coverage Δ Complexity Δ
drone/src/lib/private/DB/OCSqlitePlatform.php 66.66% <0%> (-33.34%) 5% <0%> (ø)
drone/src/lib/private/DB/SQLiteMigrator.php 71.42% <0%> (-28.58%) 7% <0%> (ø)
drone/src/lib/private/DB/SQLiteSessionInit.php 75% <0%> (-25%) 4% <0%> (ø)
...one/src/lib/private/Repair/SqliteAutoincrement.php 63.88% <0%> (-24.58%) 9% <0%> (ø)
drone/src/lib/private/DB/AdapterSqlite.php 67.56% <0%> (-18.64%) 7% <0%> (ø)
drone/src/lib/private/App/AppManager.php 86.06% <0%> (+0.28%) 78% <0%> (+1%) ⬆️
...lib/private/Repair/RepairMismatchFileCachePath.php 82.52% <0%> (+0.4%) 48% <0%> (ø) ⬇️
...e/src/lib/private/DB/QueryBuilder/QueryBuilder.php 90.74% <0%> (+0.46%) 68% <0%> (ø) ⬇️
drone/src/lib/private/DB/Connection.php 68.38% <0%> (+4.41%) 49% <0%> (ø) ⬇️
drone/src/lib/private/DB/MDB2SchemaManager.php 85.96% <0%> (+5.26%) 17% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955cc32...5341fdd. Read the comment docs.

@PVince81 PVince81 merged commit 04c0965 into master Jan 16, 2018
@PVince81 PVince81 deleted the fix-30112 branch January 16, 2018 07:29
@PVince81
Copy link
Contributor

Please backport

@VicDeo
Copy link
Member Author

VicDeo commented Jan 16, 2018

Stable10: #30150

@davitol
Copy link
Contributor

davitol commented Jan 16, 2018

Tested and works 👍

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App not found message is shown when installing an app via tarball and CLI
4 participants