-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cache app path if app is not found #30144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #30144 +/- ##
===========================================
+ Coverage 57.94% 58.24% +0.3%
- Complexity 18525 18526 +1
===========================================
Files 1094 1094
Lines 63707 63743 +36
===========================================
+ Hits 36914 37130 +216
+ Misses 26793 26613 -180
Continue to review full report at Codecov.
|
Please backport |
Stable10: #30150 |
Tested and works 👍 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Introduced in Implement AppManager::getAppPath #29871 where I made app path cache a bit more
agressive
Related Issue
Fixes #30112 #30126
Motivation and Context
Fixes
How Has This Been Tested?
php occ market:install -l ../xmas-0.0.4.tar.gz
Screenshots (if appropriate):
Types of changes
Checklist: