-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch session unavailable exception #30141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ownclouders please rebase |
6c9ab34
to
648ae89
Compare
Codecov Report
@@ Coverage Diff @@
## master #30141 +/- ##
=========================================
Coverage ? 60.8%
Complexity ? 18519
=========================================
Files ? 1092
Lines ? 61195
Branches ? 0
=========================================
Hits ? 37211
Misses ? 23984
Partials ? 0
Continue to review full report at Codecov.
|
Fixed test. Lets see if 2 out of 3 CI services managed to die again this time -.- |
@ownclouders please rebase |
@tomneedham you have to command him/her/it first - then saying please is optional |
@ownclouders rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
648ae89
to
b17d059
Compare
🙄 |
Backport stable10 #30347 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Throw the correct excpetion so that it is properly caught on the session desctructor.
Motivation and Context
When the session destructor is called this exception can bubble up unnecessarily - its the wrong type.
How Has This Been Tested?
unit tests written
Screenshots (if appropriate):
Types of changes
Checklist: