Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #30026 from owncloud/stable10-b907afe0e91e… #30072

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Revert "Merge pull request #30026 from owncloud/stable10-b907afe0e91e… #30072

merged 2 commits into from
Jan 10, 2018

Conversation

DeepDiver1975
Copy link
Member

revert #30026

@DeepDiver1975
Revert "Merge pull request #30026 from owncloud/stable10-b907afe0e91e…
1e6cdb4 
…469b479c690dd11867b063f1bf08"

This reverts commit 46c1dfe, reversing
changes made to 2e5f7c8.
@DeepDiver1975 DeepDiver1975 added this to the development milestone Jan 9, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Jan 9, 2018
@PVince81
Copy link
Contributor

PVince81 commented Jan 9, 2018

why ? because some lib updates and even non-updates seem to be bringing more additional files and is looking suspicious. So we decided to play it safe and revert for now. Work on this will continue on master for 10.1

PVince81
PVince81 approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 OC still works

@PVince81
Copy link
Contributor

PVince81 commented Jan 9, 2018

don't merge yet, pushing changelog update...

@PVince81
Copy link
Contributor

PVince81 commented Jan 9, 2018

done. let's merge after CI

@PVince81
Copy link
Contributor

Travis still in the queue 😢

@codecov
Copy link

codecov bot commented Jan 10, 2018 •
edited
Loading

Codecov Report

Merging #30072 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #30072   +/-   ##
===========================================
  Coverage       58.94%   58.94%           
  Complexity      18091    18091           
===========================================
  Files            1065     1065           
  Lines           62230    62230           
===========================================
  Hits            36681    36681           
  Misses          25549    25549

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d605d05...0713fd5. Read the comment docs.

@PVince81 PVince81 merged commit cea6c36 into stable10 Jan 10, 2018
@PVince81 PVince81 deleted the stable10-revert-yarn branch January 10, 2018 08:54
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels
4 - To release
Projects
None yet
Milestone
10.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @PVince81