Be more precise when refuse to expire

[VicDeo]

Change the wording to be more clear

Description

Change the wording to be more clear

Related Issue

#28509

Motivation and Context

Unclear output

How Has This Been Tested?

By reading the message

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[tomneedham]

Text looks good, not tested the code as it is just a string change 👍

[codecov]

Codecov Report

Merging #29646 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #29646      +/-   ##
============================================
+ Coverage     62.09%   62.16%   +0.06%     
  Complexity    17515    17515              
============================================
  Files          1045     1045              
  Lines         57746    57738       -8     
============================================
+ Hits          35858    35890      +32     
+ Misses        21888    21848      -40

Impacted Files	Coverage Δ	Complexity Δ
apps/files_trashbin/lib/Command/ExpireTrash.php	35.55% <100%> (+35.55%)	12 <0> (ø)	⬇️
apps/files_versions/lib/Command/ExpireVersions.php	36.36% <100%> (+36.36%)	12 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc38ca0...98986a5. Read the comment docs.

[DeepDiver1975]

Please add tests. Use command Tester. See other command tests like app commands

[VicDeo]

@DeepDiver1975 test that "Auto expiration is configured - expiration will be handled automatically." is actually printed char by char?

[PVince81]

@VicDeo I usually use assertContains with a few keywords. Maybe there was no actual test at all for that code path so adding one would be nice.

[DeepDiver1975]

example: https://github.com/owncloud/core/pull/24551/files#diff-53868c402aa661f06b79e3055d46e383

[VicDeo]

Covered

[PVince81]

uh oh, class name mismatch

[PVince81]

👍 fix the phpdoc and this is good to go

[VicDeo]

@PVince81 fixed, history squashed, waiting for CI

[VicDeo]

Stable10: #29671

@PVince81 what about stable9.1?

[PVince81]

If not critical I'd say no need to backport for 9.1.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.