Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Disable nginx buffering for file downloads #29403

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

jvillafanez
Copy link
Member

Description

Backport of #29400 to stable10

Related Issue

#29328

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #29403 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #29403      +/-   ##
==============================================
+ Coverage       59.25%   59.25%   +<.01%     
  Complexity      17766    17766              
==============================================
  Files            1062     1062              
  Lines           59513    59514       +1     
==============================================
+ Hits            35264    35265       +1     
  Misses          24249    24249
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Connector/Sabre/FilesPlugin.php 85.81% <100%> (+0.09%) 45 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d02bdc...1571dc3. Read the comment docs.

@DeepDiver1975 DeepDiver1975 self-requested a review November 2, 2017 12:03
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash as well please and set labels and milestone accordingly

@jvillafanez jvillafanez force-pushed the disable_nginx_buffering_on_downloads_stable10 branch from b37109f to 1571dc3 Compare November 6, 2017 07:52
@jvillafanez
Copy link
Member Author

Squashed

@PVince81 PVince81 merged commit 42a4dc5 into stable10 Nov 6, 2017
@PVince81 PVince81 deleted the disable_nginx_buffering_on_downloads_stable10 branch November 6, 2017 13:44
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants