Add user additional info field for share autocomplete

[PVince81]

Description

Related Issue

Fixes #28979

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

@pmaier1 please try it out.

We might want to tweak the visual design a bit.

[jvillafanez]

Code looks good, not tested

[jvillafanez]

We should also test with mobile devices (or small window size). UX might change

[PVince81]

@felixheidecke any suggestion the visual design ? Now having the email address appearing there makes the sidebar look more loaded. Eventually we might want to move those permissions to a sub-panel/accordion but out of scope for this PR/feature.

[PVince81]

To test please go to the settings page under the "Sharing" section where you can select what information to display with the sharee in autocomplete and in the rows.

[felixheidecke]

I added a little CSS. Looks good from a UI pov. 👍

[PVince81]

seems I need to look into test failures

[PVince81]

Added PHP unit tests, squashed, rebased.

Quick rereview appreciated @jvillafanez

[codecov]

Codecov Report

Merging #29334 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #29334      +/-   ##
============================================
+ Coverage     60.45%   60.46%   +0.01%     
- Complexity    17222    17231       +9     
============================================
  Files          1032     1032              
  Lines         57360    57381      +21     
============================================
+ Hits          34677    34698      +21     
  Misses        22683    22683

Impacted Files	Coverage Δ	Complexity Δ
settings/templates/panels/admin/filesharing.php	100% <ø> (ø)	0 <0> (ø)	⬇️
...files_sharing/lib/Controller/ShareesController.php	89.53% <100%> (+0.5%)	98 <3> (+5)	⬆️
settings/Panels/Admin/FileSharing.php	100% <100%> (ø)	6 <0> (ø)	⬇️
apps/files_sharing/lib/API/Share20OCS.php	91.62% <100%> (+0.19%)	149 <3> (+4)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2654cbc...61953ed. Read the comment docs.

[PVince81]

stable10: #29457

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.