Small tweaks for WebDavClientService and tests #29327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2017
Codecov Report
@@ Coverage Diff @@
## master #29327 +/- ##
=========================================
Coverage 60.21% 60.21%
Complexity 17183 17183
=========================================
Files 1030 1030
Lines 57280 57280
=========================================
Hits 34493 34493
Misses 22787 22787
Continue to review full report at Codecov.
|
tests/lib/Files/Storage/DavTest.php
Outdated
| */ | ||
| private $httpClientService; | ||
|
|
||
| /** | ||
| * @var IWebdavClientService | ||
| * @var IWebDavClientService | PHPUnit_Framework_MockObject_MockObject |
There was a problem hiding this comment.
should be \PHPUnit_Framework_MockObject_MockObject
or add use PHPUnit_Framework_MockObject_MockObject at the beginning of the file
PVince81
force-pushed
the
fix-webdavclientservice-review
branch
from
932fb50
to
b946b6f
Compare
|
@DeepDiver1975 adjusted, thanks |
PVince81
force-pushed
the
fix-webdavclientservice-review
branch
from
b946b6f
to
9f29e65
Compare
|
@DeepDiver1975 I've fixed the conflicts, please recheck |
|
wat... |
DeepDiver1975
approved these changes
Oct 26, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of @DeepDiver1975's review: #29220 (comment)