Better timeout detection in web UI uploads + chunked uploads #28831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
added
the
p2-high
|
it seems to break #28842 |
|
@VicDeo details please: steps to reproduce, etc |
|
note that the progress bar has an additional bug I found which I fixed here in additional commits: #28692. I suggest to first review this one then I'll rebase this timeout madness. |
added 2 commits
September 1, 2017 15:22
Displays an error message on timeout.
PVince81
force-pushed
the
webui-upload-timeouthandling
branch
from
f10288e
to
5bda4ee
Compare
|
Rebased. @VicDeo please recheck |
|
The tests decribed in the description work so far |
|
@PVince81 it just stuck in |
|
If @VicDeo has no more objections then 👍 |
|
stable10: #28896 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detects timeouts during web UI uploads and displays a notification when it happens.
Also prevents the global ajax error detection to prevent the full page reload.
Related Issue
Motivation and Context
How Has This Been Tested?
fileUploadParam. Addsleep(500)inOCA\DAV\Connector\Sabre\File::put(). Upload < 10 mb file. Notification about timeout appears.fileUploadParam. Upload 100 mb file. Notification about timeout appears.sleep(500)inapps/dav/lib/Upload/UploadFolder::createFile(), upload 100 mb file. Notification appears after 2 minutessleep(500)inapps/dav/lib/Upload/AssemblyStream::stream_open(). Upload 100 mb file, wait. Notification appears after 2 minutes of stalling at the end of the progress bar.=> cannot test, it seems IE11 doesn't have a timeout on MOVE, only on PUT
Note: remove extra modifications between each test.
Screenshots (if appropriate):
Types of changes
Checklist: