Don't use runInSeparateProcess #28676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
reviewed
Aug 14, 2017
| @@ -351,7 +355,7 @@ public function testPutSingleFile() { | |||
| * @return boolean true if negative mtime is supported | |||
| */ | |||
| private function supportsNegativeMtime() { | |||
| return (getenv("PRIMARY_STORAGE_CONFIG") !== "swift"); | |||
| return !(getenv("RUN_OBJECTSTORE_TESTS") !== false); | |||
There was a problem hiding this comment.
Is this clear as mud to you?
having the 2 "!" - I guess the construction !== false is a way of saying "if true" -> "if RUN_OBJECTSTORE_TESTS" and then the "!" at the front negates that.
but it messes my brain a bit
There was a problem hiding this comment.
but it messes my brain a bit
me too .... I need to understand the initial logic as well ... see rocket chat ....
|
@DeepDiver1975 please backport |
|
Will do asap |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is not need in running a test in a separate process ....
Motivation and Context
Clean code, better unit test execution
Types of changes
Checklist: