Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activity manager null session #28408

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Fix activity manager null session #28408

merged 2 commits into from
Jul 17, 2017

Conversation

DeepDiver1975
Copy link
Member

Description

The user session can be null under certain conditions which caused

Type error: Argument 2 passed to OC\Activity\Manager::__construct() must be an instance of OCP\IUserSession, null given, called in owncloud/lib/private/Server.php on
line 406

How Has This Been Tested?

Tests got added

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the development milestone Jul 17, 2017
PVince81
PVince81 approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code makes sense

@sharidas can you test ?

sharidas
sharidas approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying this change, my env is happy. Verified the change with scratch installation. Both with command line and from UI. 👍 Thanks

@DeepDiver1975 DeepDiver1975 merged commit 02f54ec into master Jul 17, 2017
@DeepDiver1975 DeepDiver1975 deleted the fix-activity-manager-null-session branch July 17, 2017 18:41
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 17, 2017
Merged
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@sharidas sharidas sharidas approved these changes

Assignees
No one assigned
Labels
3 - To Review status/STALE
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@DeepDiver1975 @PVince81 @sharidas @ownclouders