Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle inconsistent filecache reads #28273

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Handle inconsistent filecache reads #28273

merged 1 commit into from
Jul 4, 2017

Conversation

tomneedham
Copy link
Contributor

Description

We have some reports of many undefined indexes in the owncloud logs generated when ->get() is called with a fileid, but there is no database row. This PR fixes the cache logic to catch these cases properly and return a correct false response.

Should be backported to 10 and 9.1 as well.

How Has This Been Tested?

Running the unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tomneedham tomneedham added this to the development milestone Jun 30, 2017
@tomneedham tomneedham self-assigned this Jun 30, 2017
@tomneedham tomneedham requested a review from PVince81 June 30, 2017 15:44
@tomneedham tomneedham changed the title Handle incomplete filecache entries Handle inconsistent filecache reads Jun 30, 2017
@butonic
Copy link
Member

butonic commented Jun 30, 2017

Also fixed by #28166

PVince81
PVince81 approved these changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming you did some regression testing with desktop client

@PVince81 PVince81 merged commit 6cf443b into master Jul 4, 2017
@PVince81 PVince81 deleted the cache-quiet branch July 4, 2017 07:54
@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

@tomneedham backport ? what version was affected ?

@PVince81
Copy link
Contributor

@tomneedham please backport down to stable9, likely related to filecache corruption

@PVince81
Copy link
Contributor

@tomneedham missing backport

@tomneedham tomneedham mentioned this pull request Aug 16, 2017
Merged
@PVince81
Copy link
Contributor

stable10: #28710

@PVince81
Copy link
Contributor

backport further ?

@tomneedham tomneedham mentioned this pull request Jan 16, 2018
Merged
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@tomneedham tomneedham

Labels
3 - To Review status/STALE
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@tomneedham @butonic @PVince81 @DeepDiver1975 @ownclouders