[WIP] no trip to the db is better than a fast trip to the db #28165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No trip to the db is better than a fist trip to the db.
How to reproduce
What should happen
A sane amount of queries to the db. At least methods like getPathByID, getID and get should only query the db once unless there was a change to the filecache
What actually happens:
Click to expand 504 queries
With this PR the number of queries goes down to 68. More caching might be possible. But I think this is at least a start.
Motivation and Context
reduces exponential growth of db queries
How Has This Been Tested?
manually as outlined above
Screenshots (if appropriate):
Types of changes
Checklist: