Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only read from an existing file #28034

Merged
merged 1 commit into from
May 31, 2017
Merged

Only read from an existing file #28034

merged 1 commit into from
May 31, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented May 30, 2017 •
edited
Loading

Related Issue

fixes #27988

How Has This Been Tested?

  • tail -f data/owncloud.log
  • open apps in settings page
  • observer no errors anymore

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.1 milestone May 30, 2017
@SergioBertolinSG
Copy link
Contributor

Works 👍

@DeepDiver1975 DeepDiver1975 merged commit a02dc57 into master May 31, 2017
@DeepDiver1975 DeepDiver1975 deleted the fix-file_get_contents-signature.json branch May 31, 2017 06:37
@phil-davis
Copy link
Contributor

Note: The Travis failure on UI tests here on merge should be improved by the more robust UI testing changes also merged at around the same time. We will see how tests of later merges go.

@phisch phisch mentioned this pull request Jun 2, 2017
Merged
@PVince81
Copy link
Contributor

PVince81 commented Jun 2, 2017

@DeepDiver1975 backport to stable10 ?

@DeepDiver1975 DeepDiver1975 modified the milestones: 10.1, development Oct 10, 2017
@PVince81
Copy link
Contributor

PVince81 commented Nov 3, 2017

@DeepDiver1975 please backport

@DeepDiver1975 DeepDiver1975 mentioned this pull request Nov 3, 2017
Merged
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

Assignees

@DeepDiver1975 DeepDiver1975

Labels
4 - To release
Projects
None yet
Milestone
10.0.5
Development

Successfully merging this pull request may close these issues.

Failures when getting some signature.json files from apps.
4 participants
@DeepDiver1975 @SergioBertolinSG @phil-davis @PVince81