-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only VEVENT for birthday calendar and default order to 1 #28011
Conversation
7eec4f0
to
66dca8c
Compare
@DeepDiver1975 I can't find the code path for accepting an event from another user and where it is inserted into your calendar? Wanted to check where the logic is for choosing the calendar to insert it into. |
@DeepDiver1975 hmm so I see there is already a migration to fix this - https://github.com/owncloud/core/pull/25636/files but annoyingly the fix didn't work. How often is that repair step called - as we still have corrupt birthday calendars |
fixes #26746 ❓ |
It is within the sabre dav libs: this propfind handles the calendar selection - https://github.com/fruux/sabre-dav/blob/master/lib/CalDAV/Schedule/Plugin.php#L240 |
best would be to add a migration from my pov |
66dca8c
to
afbe709
Compare
yes should do - since I just push the birthday to the bottom of the users list |
2d22867
to
1a6987e
Compare
1a6987e
to
902ceb0
Compare
->execute(); | ||
|
||
$output->info("$updated birthday calendars updated."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep the logging in here
902ceb0
to
c560045
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
New calendars are given a default order of 1, to always be after the default birthday calendar.
The system birthday calendar is created with VEVENT only, not VTODO as this is not possible.
Motivation and Context
Causes issues when the birthday calendar is used for accepting events or if TODOs are created in that calendar.
How Has This Been Tested?
before:
after:
Screenshots (if appropriate):
Types of changes
Checklist: