Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite a git clone of an app with code from the marketplace #27973

Merged
merged 1 commit into from
May 22, 2017
Merged

Don't overwrite a git clone of an app with code from the marketplace #27973

merged 1 commit into from
May 22, 2017

Conversation

DeepDiver1975
Copy link
Member

Description

It is very annoying when ./occ upgrade grabs an app from the marketplace and kills a local app installation.

Motivation and Context

Don't annoy developers

How Has This Been Tested?

  • grab e.g. the market app from github
  • run occ upgrade
  • see that the local clone is not killed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 22, 2017
@PVince81
Copy link
Contributor

Code looks good 👍

@PVince81 PVince81 merged commit cb6f4a2 into master May 22, 2017
@PVince81 PVince81 deleted the dont-kill-app-git-clones branch May 22, 2017 11:25
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @PVince81