Newdav maintenancemode #27821

PVince81 · 2017-05-05T14:14:58Z

Description

Enable maintenance mode plugin also for the new DAV endpoint.

Related Issue

Fixes owncloud/client#5738

How Has This Been Tested?

Integration tests.
Local test with a simple PROPFIND with maintenance mode enabled.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Tagged as critical because it causes data loss with "Local" external storage and potentially other system-wide storages.

Needs backport to stable9.1.

@SergioBertolinSG I need your help with behat: the @AfterScenario that disables maintenance mode after the test runs too late. So while the tests pass, the other @AfterScenario code fails because maintenance mode is still active at this point. Any ideas how to change the priority ?

@DeepDiver1975 please review the fix

DeepDiver1975

🤕

ckamm · 2017-05-08T08:56:09Z

Works for me

PVince81 · 2017-05-08T09:14:24Z

tests/integration/config/behat.yml

@@ -13,15 +13,15 @@ default:
              - admin
            regular_user_password: 123456
            mailhog_url: http://127.0.0.1:8025/api/v2/messages
+        - CommandLineContext:
+            baseUrl: http://localhost:8080
+            ocPath: ../../


PVince81 · 2017-05-08T10:21:16Z

Rebased for CI

PVince81 · 2017-05-09T08:43:32Z

14:37:46     /var/lib/jenkins/workspace/owncloud-core_core_PR-27821-CG35ITJCHSNDATF4YR5HHRU2J7EA77TPHL4EG53CZCPDPGIQ2GDA/tests/integration/features/webdav-related-new-endpoint.feature:5
14:37:46     /var/lib/jenkins/workspace/owncloud-core_core_PR-27821-CG35ITJCHSNDATF4YR5HHRU2J7EA77TPHL4EG53CZCPDPGIQ2GDA/tests/integration/features/webdav-related-new-endpoint.feature:547
14:37:46     /var/lib/jenkins/workspace/owncloud-core_core_PR-27821-CG35ITJCHSNDATF4YR5HHRU2J7EA77TPHL4EG53CZCPDPGIQ2GDA/tests/integration/features/webdav-related-old-endpoint.feature:5
14:37:46     /var/lib/jenkins/workspace/owncloud-core_core_PR-27821-CG35ITJCHSNDATF4YR5HHRU2J7EA77TPHL4EG53CZCPDPGIQ2GDA/tests/integration/features/webdav-related-old-endpoint.feature:490

PVince81 · 2017-05-09T12:03:15Z

one more remaining, will have a look:

/var/lib/jenkins/workspace/owncloud-core_core_PR-27821-CG35ITJCHSNDATF4YR5HHRU2J7EA77TPHL4EG53CZCPDPGIQ2GDA/tests/integration/features/webdav-related-old-endpoint.feature:490

PVince81 · 2017-05-09T12:10:18Z

boohoo the tests from this file pass locally

PVince81 · 2017-05-09T12:17:43Z

more exact output from Jenkins (which I do not see locally):

13:15:57   Scenario: Maintenance mode                        # /var/lib/jenkins/workspace/owncloud-core_core_PR-27821-CG35ITJCHSNDATF4YR5HHRU2J7EA77TPHL4EG53CZCPDPGIQ2GDA/tests/integration/features/webdav-related-old-endpoint.feature:490
13:15:58     Given maintenance mode is enabled               # CommandLineContext::maintenanceModeIs()
13:15:58 [Tue May  9 13:15:58 2017] ::1:54497 [207]: /remote.php/webdav
13:15:58     When Connecting to dav endpoint as user "admin" # FeatureContext::connectingToDavEndpointAsUser()
13:15:58     Then the HTTP status code should be "503"       # FeatureContext::theHTTPStatusCodeShouldBe()
13:15:58       Failed asserting that 207 matches expected '503'.
13:15:58 [Tue May  9 13:15:58 2017] ::1:54502 [207]: /remote.php/dav/systemtags/
13:15:58 [Tue May  9 13:15:58 2017] Login failed: 'user0' (Remote IP: '::1')
13:15:59 [Tue May  9 13:15:58 2017] ::1:54505 [401]: /remote.php/webdav/myFileToTag.txt
13:15:59 [Tue May  9 13:15:59 2017] ::1:54506 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
13:15:59 [Tue May  9 13:15:59 2017] ::1:54509 [404]: /remote.php/dav/calendars/admin/MyCalendar

SergioBertolinSG · 2017-05-09T12:20:09Z

It is connecting using "admin" but you have changed it here 4787fb7#diff-dc84a6418f59a28b93942dd9dd005b6bR842

PVince81 · 2017-05-09T12:27:58Z

@SergioBertolinSG but then it should fail locally ? Are you able to reproduce it ?

PVince81 · 2017-05-09T12:39:25Z

It is connecting using "admin" but you have changed it here 4787fb7#diff-dc84a6418f59a28b93942dd9dd005b6bR842

Connecting as "admin" in the maintenance tests is the correct scenario.

Tried re-checking out the branch locally, removing all extra apps, the test still doesn't fail.

SergioBertolinSG · 2017-05-09T13:25:19Z

Nevermind my previous comment.

It is working fine for me:

[Tue May  9 13:24:13 2017] Exception: {"Message":"HTTP\/1.1 503 System in maintenance mode.","Exception":"Sabre\\DAV\\Exception\\ServiceUnavailable","Code":0,"Trace":"#0 [internal function]: OCA\\DAV\\Connector\\Sabre\\MaintenancePlugin->checkMaintenanceMode(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#1 \/var\/www\/html\/trashbin_vincent\/lib\/composer\/sabre\/event\/lib\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\n#2 \/var\/www\/html\/trashbin_vincent\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(466): Sabre\\Event\\EventEmitter->emit('beforeMethod', Array)\n#3 \/var\/www\/html\/trashbin_vincent\/lib\/composer\/sabre\/dav\/lib\/DAV\/Server.php(254): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#4 \/var\/www\/html\/trashbin_vincent\/apps\/dav\/appinfo\/v1\/webdav.php(63): Sabre\\DAV\\Server->exec()\n#5 \/var\/www\/html\/trashbin_vincent\/remote.php(165): require_once('\/var\/www\/html\/t...')\n#6 {main}","File":"\/var\/www\/html\/trashbin_vincent\/apps\/dav\/lib\/Connector\/Sabre\/MaintenancePlugin.php","Line":83,"User":false}
[Tue May  9 13:24:13 2017] 127.0.0.1:33919 [503]: /remote.php/webdav
    When Connecting to dav endpoint as user "admin" # FeatureContext::connectingToDavEndpointAsUser()

SergioBertolinSG · 2017-05-09T15:25:32Z

I can reproduce this moving this scenario https://github.com/owncloud/core/pull/27821/files#diff-0d2db90e35aaf54e2c763f470420c026R547

into webdav-related-old-endpoint.feature.

I think the problem happens when running all the tests together. When running isolated it doesn't fail.

PVince81 · 2017-05-09T15:32:12Z

So it's likely a side effect ? Maybe in some case the maintenance mode isn't properly disabled

SergioBertolinSG · 2017-05-09T15:33:38Z

I'm trying something, I'll tell you if it succeds.

PVince81 · 2017-05-10T15:37:23Z

Tests are delayed now. We're experiencing env issues and potential race conditions.

So far it seems that while maintenance mode is enabled, the call still goes through when running the test on some env, and only sometimes. 1 of 5 test runs on the same env will fail... Suspecting PHP 7 bug with proc_close so far which maybe doesn't wait for the command to finish.

Needs further research...

PVince81 · 2017-05-10T15:50:20Z

Observed so far:

Jenkins has PHP 7.0.10 and has this failure
@SergioBertolinSG's env has PHP 7.0.11 and it fails there too, but randomly
my env has PHP 7.0.15 and I don't see any failure (had the tests running in a loop)

SergioBertolinSG · 2017-05-10T17:01:49Z

After adding this:

diff --git a/apps/dav/lib/Connector/Sabre/MaintenancePlugin.php b/apps/dav/lib/Connector/Sabre/MaintenancePlugin.php
index e648dce5e6..bf309b0aa0 100644
--- a/apps/dav/lib/Connector/Sabre/MaintenancePlugin.php
+++ b/apps/dav/lib/Connector/Sabre/MaintenancePlugin.php
@@ -76,6 +76,7 @@ class MaintenancePlugin extends ServerPlugin {
         * @return bool
         */
        public function checkMaintenanceMode() {
+       \OCP\Util::writeLog('DEBUG', 'maintenance: ' . $this->config->getSystemValue('maintenance', false), \OCP\Util::DEBUG);
                if ($this->config->getSystemValue('singleuser', false)) {
                        throw new ServiceUnavailable('System in single user mode.');
                }

And run with log level 0, I can see

And maintenance mode is enabled # CommandLineContext::maintenanceModeIs()
[Wed May 10 16:24:24 2017] maintenance: 
[Wed May 10 16:24:24 2017] 127.0.0.1:51562 [207]: /remote.php/dav/files/admin
When Connecting to dav endpoint as user "admin" # FeatureContext::connectingToDavEndpointAsUser()
Then the HTTP status code should be "503" # FeatureContext::theHTTPStatusCodeShouldBe()
Failed asserting that 207 matches expected '503'.

The enabling maintenance mode doesn't seems to work fine.

PVince81 · 2017-05-10T20:18:17Z

Let's not waste more time on this testing issue and get the main fix merged.
We can continue researching this weird behavior in a separate PR that adds maintenance mode tests. I don't see these tests as really critical or helpful in the short term.

PVince81 · 2017-05-10T20:18:33Z

I'll take care of the splitting tomorrow

PVince81 · 2017-05-11T08:36:07Z

I've removed the test related commits from this PR, so only the fix remains.

The tests were moved to another branch and PR here #27856

PVince81 · 2017-05-11T08:45:51Z

stable9.1: #27857

PVince81 · 2017-05-12T08:42:52Z

[ERROR] Waited 600 seconds, no response

PVince81 · 2017-05-12T08:44:22Z

rebased...

lock · 2019-08-03T10:02:29Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

PVince81 added the sev1-critical label May 5, 2017

PVince81 mentioned this pull request May 5, 2017

[10.0.0] The ownCloud desktop client is temporarily removing most of my files locally when server gets into maintenance mode owncloud/client#5738

Closed

DeepDiver1975 self-requested a review May 5, 2017 14:38

DeepDiver1975 added this to the 10.0.1 milestone May 5, 2017

DeepDiver1975 approved these changes May 5, 2017

View reviewed changes

PVince81 commented May 8, 2017

View reviewed changes

PVince81 added backport-request 4 - To release labels May 8, 2017

PVince81 force-pushed the newdav-maintenancemode branch from f38dba5 to 41ecb37 Compare May 8, 2017 10:21

PVince81 added 2 - Developing 3 - To Review and removed 4 - To release 2 - Developing labels May 9, 2017

SergioBertolinSG force-pushed the newdav-maintenancemode branch from 7081978 to 3c0caec Compare May 10, 2017 06:52

felixboehm added the p1-urgent Critical issue, need to consider hotfix with just that issue label May 10, 2017

PVince81 force-pushed the newdav-maintenancemode branch from 3c0caec to 3cbe4fb Compare May 11, 2017 08:34

PVince81 mentioned this pull request May 11, 2017

Tests maintenancemode endpoint #27856

Closed

PVince81 added 4 - To release and removed 3 - To Review labels May 11, 2017

PVince81 mentioned this pull request May 11, 2017

[stable9.1] Add maintenance mode plugin to new dav endpoint #27857

Merged

Add maintenance mode plugin to new dav endpoint

b0c7dd4

PVince81 force-pushed the newdav-maintenancemode branch from 3cbe4fb to b0c7dd4 Compare May 12, 2017 08:44

DeepDiver1975 merged commit 9f644c4 into master May 12, 2017

DeepDiver1975 deleted the newdav-maintenancemode branch May 12, 2017 09:17

PVince81 removed the backport-request label Aug 15, 2017

lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Newdav maintenancemode #27821

Newdav maintenancemode #27821

PVince81 commented May 5, 2017

DeepDiver1975 left a comment

ckamm commented May 8, 2017

PVince81 May 8, 2017

PVince81 commented May 8, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

SergioBertolinSG commented May 9, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

SergioBertolinSG commented May 9, 2017 •

edited

Loading

SergioBertolinSG commented May 9, 2017

PVince81 commented May 9, 2017

SergioBertolinSG commented May 9, 2017

PVince81 commented May 10, 2017

PVince81 commented May 10, 2017

SergioBertolinSG commented May 10, 2017 •

edited

Loading

PVince81 commented May 10, 2017

PVince81 commented May 10, 2017

PVince81 commented May 11, 2017

PVince81 commented May 11, 2017

PVince81 commented May 12, 2017 •

edited

Loading

PVince81 commented May 12, 2017

lock bot commented Aug 3, 2019

Newdav maintenancemode #27821

Newdav maintenancemode #27821

Conversation

PVince81 commented May 5, 2017

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

DeepDiver1975 left a comment

Choose a reason for hiding this comment

ckamm commented May 8, 2017

PVince81 May 8, 2017

Choose a reason for hiding this comment

PVince81 commented May 8, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

SergioBertolinSG commented May 9, 2017

PVince81 commented May 9, 2017

PVince81 commented May 9, 2017

SergioBertolinSG commented May 9, 2017 • edited Loading

SergioBertolinSG commented May 9, 2017

PVince81 commented May 9, 2017

SergioBertolinSG commented May 9, 2017

PVince81 commented May 10, 2017

PVince81 commented May 10, 2017

SergioBertolinSG commented May 10, 2017 • edited Loading

PVince81 commented May 10, 2017

PVince81 commented May 10, 2017

PVince81 commented May 11, 2017

PVince81 commented May 11, 2017

PVince81 commented May 12, 2017 • edited Loading

PVince81 commented May 12, 2017

lock bot commented Aug 3, 2019

SergioBertolinSG commented May 9, 2017 •

edited

Loading

SergioBertolinSG commented May 10, 2017 •

edited

Loading

PVince81 commented May 12, 2017 •

edited

Loading