[stable9.1] Setupfs before access a users keys

[DeepDiver1975]

port of #26820

[PVince81]

Cherry-picked the additional commit

[PVince81]

Looks like we still have some unit test failures.

Automated tests will be added as part of #26844.
I could already confirm that some tests had failed with alternate home + encryption and this PR here solves them.

[PVince81]

Cherry-picked additional test fixes from the master branch.

@jvillafanez please review

[PVince81]

Argh, need to replace createMock with getMock. Will do...

[PVince81]

Okay, should be good to go now.

[jvillafanez]

👍

[PVince81]

Let's wait before merging. Need to investigate this (not-so-critical-but-still) regression #26935

[PVince81]

Parse error: ./tests/lib/Encryption/Keys/StorageTest.php:72

    70| 			->getMock();

    71| 

  > 72| 		$user = $this->getMock(IUser::class);

    73| 		$user->method('getUID')->willReturn('user1');

    74| 		$userSession = $this->getMock(IUserSession::class);

Unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$'

I'll adjust this later when rebasing.

[PVince81]

• TODO: fix unit test syntax error
• TODO: cherry-pick the regression fix: Use preDelete hook to delete encryption keys #26938
• TODO: cherry-pick the other relevant fix about alternative home dir: Don't mount user home with alternate keys root #26937

[felixboehm]

fix works fine in my production environment

[PVince81]

Need rereview, I cherry-picked backports of master to fix a regression and incomplete cases.

[jvillafanez]

My only worry is that this should be done after deleting the user. If the user isn't deleted, we'd already have deleted the keys with the current code.

Maybe if the keys are stored in the user's home and we can't access to it, we could suppose the keys are already deleted. If they're stored elsewhere we can delete them without problem after the user is deleted.

[PVince81]

Hmm, then I should revert #26938 and find a better way

[PVince81]

• revert preDelete fix and find a better solution
• fix PHP 5.4 syntax error

Parse error: ./tests/lib/Encryption/Keys/StorageTest.php:296

    294| 			->willReturn(true);

    295| 

  > 296| 		$user = $this->createMock(IUser::class);

    297| 		$user->method('getUID')->willReturn('user1');

    298| 		$userSession = $this->createMock(IUserSession::class);

Unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$'

[PVince81]

@jvillafanez please review #26968 with an alternative solution to the preDelete problem. Have to revert and refix on master before I can cherry-pick the new solution here.

[PVince81]

Rebased and removed the "preDelete" commit and cherry-picked the better fix from #26968

[PVince81]

After all these additions, let's retest this:

• TEST: sharing with alt home works
• TEST: delete user works with no warnings
• TEST: delete user works with no warnings when using alternative key storage

[PVince81]

• backport the integration tests from Integration test encryption homedir #26844

[PVince81]

Parse error: ./tests/lib/Encryption/Keys/StorageTest.php:296

    294| 			->willReturn(true);

    295| 

  > 296| 		$user = $this->createMock(IUser::class);

    297| 		$user->method('getUID')->willReturn('user1');

    298| 		$userSession = $this->createMock(IUserSession::class);

Unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$'

😢

[PVince81]

Integrations test backport pending to be merged #26976

[jvillafanez]

Changes look good 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.