Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.2] Show avatar in share drop down #25976

Merged
merged 2 commits into from
Oct 6, 2016
Merged

[9.2] Show avatar in share drop down #25976

merged 2 commits into from
Oct 6, 2016

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 29, 2016

Description

The share dropdow now shows the avatar of the user.
TODO:

  • add avatar of a remote user

Screenshots (if appropriate):

bildschirmfoto von 2016-08-30 00-40-46

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Aug 29, 2016
@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @PVince81 and @nickvergessen to be potential reviewers

display: flex;
}
.autocomplete-item-text {
margin: 10px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DUDE, that's now how you center text vertically 😉

@PVince81
Copy link
Contributor

PVince81 commented Oct 5, 2016

Looks good so far, let me see if I can center all the things properly

@@ -50,6 +50,13 @@
height: 32px;
}

.autocomplete-item {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global namespace pollution, is likely to disturb other autocomplete boxes. let's see if we can give that specific autocomplete an additional class

@PVince81
Copy link
Contributor

PVince81 commented Oct 5, 2016

Fixed alignment, looks good now 👍

@DeepDiver1975 please review my changes.
For the remote avatar stuff, let's do it separately and merge this!

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants