[9.2] Adding a button to the detailed view where the webdav url can be copi… #25757
Conversation
|
Thanks @DeepDiver1975 ! |
Having these two buttons so close here doesn't feel comfortable and rather confusing. I wonder if we should put them both under the link part, basically it would expand with two fields instead of one. Might look ugly though. |
| @@ -18,6 +18,7 @@ | |||
| '<span class="icon icon-public"></span>' + | |||
| '<span class="hidden-visually">{{permalinkTitle}}</span>' + | |||
| '</a>' + | |||
| '<a class="{{#unless showWebDavCopyButton}}hidden-visually{{/unless}} clipboardButton icon icon-external" data-clipboard-text="{{webDavUrl}}"></a>' + | |||
There was a problem hiding this comment.
it should be "hidden", not "hidden-visually".
"hidden-visually" is used for screen readers so they can still read an icon's label even when we don't want to show it visually.
DeepDiver1975
force-pushed
the
wevdav-link-in-details
branch
2 times, most recently
from
3c9c969
to
b7c5ba4
Compare
DeepDiver1975
force-pushed
the
wevdav-link-in-details
branch
from
b7c5ba4
to
844dd44
Compare
VicDeo
force-pushed
the
wevdav-link-in-details
branch
from
844dd44
to
458c8f1
Compare
…ed to the clipboard
- use hidden instead of hidden-visually - add tooltip - use notifications on copy of the dav url- tooltip is used for the description of the button
DeepDiver1975
force-pushed
the
wevdav-link-in-details
branch
from
458c8f1
to
2948482
Compare
|
I think it would be best to have both links in the dropdown from the permalink to avoid cluttering the UI. |
|
@DeepDiver1975 update or close ? conflicts detected. also see comments above |
|
considering that most users use the desktop client, I don't see much value in exposing the current Webdav path in such an exposed location. The Webdav path is rather something internal to ownCloud and would qualify as "advanced usage" so should maybe be put somewhere else. |
the use case behind this is that a user can easily copy the web dav path to mount the folder in the operating system's file manager. seems to be a legitimate use case - maybe? @pmaier1 originally requested by @MTRichards |
|
now one idea to keep both could be to do like github used to do and have a "tab button" on top of the link that says "Private link" and "Webdav link". It would show "Private link" by default but you can switch to "Webdav link" if you want the Webdav format of it. It's better than two separate fields or two separate buttons. Apparently Github now changed the git URL and have it with a link instead to switch to "https" mode: |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
…ed to the clipboard
The webdav url to a folder can now easily be copied to the clipboard using this new button on the detailed view.
This is valuable for users who want to mount a specific folder in e.g. their windows explorer, nautilus file manager and so on ....