Pluggable auth #24189
Merged
Pluggable auth #24189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <default_enable/> | ||
| <types> | ||
| <!-- this is used to disable the feature of enabling an app for specific groups only because this would break this app --> | ||
| <filesystem/> |
There was a problem hiding this comment.
Remove, authentication also blocks disabling such apps
There was a problem hiding this comment.
This provider app example will be removed, it's just there for testing purposes
|
|
||
| /** | ||
| * @param string $token | ||
| * @return boolean|string user UID if token is valid, false when invalid |
There was a problem hiding this comment.
I'm personally not a huge fan of APIs that return multiple types. Can we make it throw an exception when invalid?
There was a problem hiding this comment.
yes, using an exception sounds better
ChristophWurst
force-pushed
the
pluggable-auth
branch
2 times, most recently
from
b51cfe1
to
9efb81f
Compare
ChristophWurst
force-pushed
the
pluggable-auth
branch
2 times, most recently
from
94e9f01
to
a9de92b
Compare
| * @param array $errors | ||
| * @param string[] $messages | ||
| */ | ||
| public static function displayLoginPage($errors = array(), $messages = []) { |
There was a problem hiding this comment.
Isn't that like, dead in master? :)
add some range to time() assertions
DeepDiver1975
force-pushed
the
pluggable-auth
branch
from
951a783
to
0486d75
Compare
This was referenced May 17, 2016
Closed
ghost
mentioned this pull request
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revives #1975I removed the two-factor code from this PR to keep it simple.
TODO:
Invalidate tokens if the session is killed in base.php?-> Invalidate browser session token when maximum session lifetime is reached #24542curl --request POST -F 'user=youruser' -F 'password=yourpassword' localhost:8080/token/generateDon't use sessions if the client sends an auth token-> Don't use session if the client uses an auth token #24543BUGS:
Changing own password kicks you out, hence the session token needs to be updated on password change-> Changing own password logs you out #24544Not possible to add an account to the desktop client – I suspect the login url change to cause that. @LukasReschke what are we gonna do about that?It works, I was testing with wrong credentials 🙈"Unable to generate a URL for the named route \\\"login#showLoginForm\\\" as such route does not exist.ORA-12899: value too large for column "AUTOTEST"."oc_authtoken"."token" (actual: 128, maximum: 100)Next steps (follow-up PRs):