Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkboxes #23063

Merged
merged 6 commits into from
Apr 12, 2016
Merged

Checkboxes #23063

merged 6 commits into from
Apr 12, 2016

Conversation

Henni
Copy link
Contributor

@Henni Henni commented Mar 9, 2016

fixes #19741
fixes #19743

@jancborchardt I'm still missing some icons. Can you add them to this PR please?

image

Checkbox

  • normal
  • indeterminate
  • checked
  • disabled
  • indeterminate + disabled
  • checked + disabled

Checkbox White

  • normal
  • indeterminate
  • checked
  • disabled
  • indeterminate + disabled
  • checked + disabled

image

Radio

  • normal
  • checked
  • disabled
  • checked + disabled

Radio White

  • normal
  • checked
  • disabled
  • checked + disabled

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @nickvergessen to be a potential reviewer

@Henni
Copy link
Contributor Author

Henni commented Apr 2, 2016

ping @jancborchardt

@nickvergessen
Copy link
Contributor

what about the missing icons?

@jancborchardt
Copy link
Member

The radio white: checked, disabled and checked+disabled are the same as the normal radio ones.

The checkbox white checked+disabled is also the same as the normal one.

Added the missing checkbox-mixed-disabled icon – also the same for both normal and white.

@MorrisJobke
Copy link
Contributor

@Henni Any chance to get the code for your tests in a building block example app? To easily show what CSS building blocks are there and to easily test, if all is still working with a new version?

@Henni
Copy link
Contributor Author

Henni commented Apr 11, 2016

@MorrisJobke I have already worked on such an example app.
I might revive it and publish it on github.

@Henni
Copy link
Contributor Author

Henni commented Apr 11, 2016

Current state (ready for review):
image

@MorrisJobke
Copy link
Contributor

I think the png file isn't needed.

beside that: 👍

@Henni
Copy link
Contributor Author

Henni commented Apr 11, 2016

@MorrisJobke We should probably remove all png files for checkboxes/radios.
Should this be part of this PR?

@MorrisJobke
Copy link
Contributor

Should this be part of this PR?

Not really, but adding unneeded files should be addressed in this PR ;)

@Henni
Copy link
Contributor Author

Henni commented Apr 11, 2016

@MorrisJobke fixed.
Should this be squashed or is it good as it is?

@MorrisJobke
Copy link
Contributor

Should this be squashed or is it good as it is?

Squashing is always nice, but we now could squash on merge because GitHub supports it now :)

@jancborchardt
Copy link
Member

👍 nice!

@MorrisJobke MorrisJobke added this to the 9.1-current milestone Apr 11, 2016
@DeepDiver1975 DeepDiver1975 merged commit c7482ee into master Apr 12, 2016
@DeepDiver1975 DeepDiver1975 deleted the checkboxes branch April 12, 2016 07:47
@nickvergessen nickvergessen mentioned this pull request Jul 19, 2016
Merged
2 tasks
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
4 - To release design enhancement
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.

Add custom radio input styling Add indeterminate style to checkboxes
6 participants
@Henni @mention-bot @nickvergessen @jancborchardt @MorrisJobke @DeepDiver1975