Harden updater authentication #22276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karlitschek @VicDeo @DeepDiver1975 Please review. |
|
👍 |
|
👍 Can we do a bit longer then 2 hours please? I'm worried that we are running into timeout situation here. I don't think there is harm done when we do 2 days instead of 2 hours. |
|
Fair enough. Let's make it two days, considering this change it's also not that critical anymore as before. |
- Reset tokens after 2 hours as discussed at owncloud/updater#220 (comment) - Used BCrypt for storing the password in the config.php. This makes it substantially harder in case of a leakage of the token to bruteforce it. In the future we can evaluate also an HMAC including the IP. That's a bit tricker though at the moment considering that we support reverse proxies. Didn't feel brave enough to touch that dragon now as well ;)
LukasReschke
force-pushed
the
harden-updater-auth
branch
from
1c44692
to
5680743
Compare
|
2 days it is 😉 |
|
👍 Tested |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 10, 2016
Harden updater authentication
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason behind this that if somebody is able to read the config file somehow this won't immediately result in a RCE.
Requires owncloud/updater#239