Fixes: Error PHP Array to string conversion at .../oc/lib/private/template/functions.php#36 #18921

zyrill · 2015-09-09T08:06:29Z

See #17468 for bug description.

scrutinizer-notifier · 2015-09-09T08:06:40Z

karlitschek · 2015-09-09T12:21:40Z

lib/private/template/functions.php

@@ -33,7 +33,7 @@
 * @param string|array $string the string which will be escaped and printed
 */
 function p($string) {
-	print(OC_Util::sanitizeHTML($string));
+	implode(print(OC_Util::sanitizeHTML($string)));


Shouldn't this be print(implode( ?

Maybe something like:

if(is_array($string)) { $string = implode($string); } print(OC_Util::sanitizeHTML($string));

👍 to @MorrisJobke 's improvement, otherwise implode() will eat the input string and return null.

like it. 👍 :)

print(implode( doesn't work by the way. don't do it! will break everything... end of the world stuff. you know, hellfire raining from the skies. think sulfur burning. or that fat guy after having a lot of onions...

@zyrill Can you fix your PR with the suggested improvements?

yes, I will. I'm in a meeting now, give me a few hours.

zyrill · 2015-09-15T13:02:33Z

@MorrisJobke anything else I need to do? I'm rather new to the github experience...

szepeviktor · 2015-09-16T17:38:38Z

👍

szepeviktor · 2015-09-16T17:41:12Z

sanitizeHTML() is prepared for an array.

function p($string) {
    $sanitized = OC_Util::sanitizeHTML($string);
    if (is_array($sanitized)) {
        $sanitized = implode($sanitized);
    }
    print $sanitized;
 }

MorrisJobke · 2015-09-23T14:29:34Z

lib/private/template/functions.php

+	if (is_array($sanitized)) {
+		$sanitized = implode($sanitized);
+	}
+	print $sanitized;


Sorry for nitpicking: can you please add brackets after print? For coding guidelines compliance ;)

Thanks.

I was the one who left it out. Sorry.

I've just applied this to 8.1.3 and it doesn't work!

Get an error message:

Error occurred while checking server setup

I've just applied this to 8.1.3 and it doesn't work!

It is still in development.

widac · 2015-09-28T20:50:02Z

Hello, I am not familar with how this works on this page.

I just want to say I've tested this to 8.1.3 and this code works for me

function p($string) {
        $sanitized = OC_Util::sanitizeHTML($string);  
 if (is_array($sanitized)) {  
        $sanitized = implode($sanitized);  
    }  
    print ($sanitized);

Thanks.

ronniehd · 2015-10-05T20:32:47Z

The above fix by @widac doesn't work for me on 8.1.3, i got blank page accessing to owncloud webui after that.
Reverting back to:

function p($string) {
    print(OC_Util::sanitizeHTML($string));
}

zyrill · 2015-10-06T08:33:04Z

Alright, got the brackets in. Any more comments?

MorrisJobke · 2015-10-06T08:47:46Z

Alright, got the brackets in. Any more comments?

Can we get the 11 commits squashed into 1 because it only changes 5 lines. ;)

Then I think this is fine for review. If you need help by juggling with git feel free to ping me in IRC (#owncloud-dev on freenode)

szepeviktor · 2015-10-06T10:46:14Z

git reset HEAD~11

@MorrisJobke

…wncloud/lib/private/template/functions.php#36 See #17468 for bug description. Incorporated changes proposed by @MorrisJobke and by @szepeviktor, see #18921

szepeviktor · 2015-10-06T14:44:15Z

:hurray:

zyrill · 2015-10-06T14:51:21Z

Puh, wär hätte gedacht, dass squashen so schwierig ist. Danke, @MorrisJobke. :)

MorrisJobke · 2015-10-06T15:02:19Z

@zyrill Because you asked about CI - I created a local branch and PR to trigger CI: #19612

@DeepDiver1975 We need to focus on CI for forks after the release ;)

PVince81 · 2015-10-20T09:47:25Z

@LukasReschke what do you think ?

LukasReschke · 2015-10-25T16:55:16Z

Fair enough from my PoV. Though I'd vote only for master and no backport.

mmattel · 2015-10-27T13:16:29Z

Any update on this? I also got this error on a fresh install on stable 8.2

EtienneBruines · 2015-10-27T14:31:24Z

The checks are failing; that's not good.

But I'm here to confirm that it (=changing that 1 function) did fix the error I had on fresh install (stable 8.2.0).

MorrisJobke · 2015-10-27T14:37:16Z

@nickvergessen @PVince81 @LukasReschke Lets get this in :)

MorrisJobke · 2015-10-27T14:37:21Z

Please review ;)

mmattel · 2015-10-27T14:39:54Z

👍 I tested on stable 8.2 and the error did not raise again

nickvergessen · 2015-10-27T14:49:07Z

I'm not sure, when it's an array it still fails to implode.
So my suggestion would be to throw a real error when it is called with an array?

szepeviktor · 2015-10-27T15:17:55Z

It is meant to be called with an array:
https://github.com/zyrill/core/blob/master/lib/private/template/functions.php#L33

MorrisJobke · 2015-10-27T15:20:28Z

It is meant to be called with an array:
https://github.com/zyrill/core/blob/master/lib/private/template/functions.php#L33

This is the weird thing ... The problem here is that it is kind of public API ... cc @DeepDiver1975

MorrisJobke · 2015-10-27T15:20:58Z

This is the weird thing ... The problem here is that it is kind of public API ... cc @DeepDiver1975

Should we change the PHPDoc - it doesn't work before anyways.

zyrill · 2015-10-27T15:37:52Z

Anything needed that I can help with?

MorrisJobke · 2015-10-27T15:38:26Z

Anything needed that I can help with?

We first need a consensus ;)

PVince81 · 2015-11-17T17:06:51Z

Do we actually know where the original error comes from ? Which template/app is calling this function with an array ?

MorrisJobke · 2015-11-23T09:05:31Z

Do we actually know where the original error comes from ? Which template/app is calling this function with an array ?

I activated contacts and calendar. Both don't throw the error on the admin page anymore.

I guess we should simply fix the PHPDoc to only accept string and then fix malicious usage of p() with an array as parameter. Otherwise we will get into the "black magic coding" again. @PVince81 @nickvergessen Opinions on this?

nickvergessen · 2015-11-23T11:05:09Z

yes, agreeed

MorrisJobke · 2015-11-23T11:12:44Z

yes, agreeed

#20679

MorrisJobke · 2015-11-23T12:35:02Z

Sorry for saying this: We will close this here and need to check where this method is called in the wrong way.

If you have still this problem it would be nice to get a stack trace or at least all installed apps including their versions.

Thanks

bcutter · 2016-08-15T11:53:43Z

Hi, this is definitely not fixed. I need to manually apply the fix in functions.php now since 2015-11-19 after every single Owncloud update.

sudo -u www-data php /var/www/owncloud/occ status
  - installed: true
  - version: 9.0.4.1
  - versionstring: 9.0.4
  - edition:

sudo -u www-data php /var/www/owncloud/occ app:list
Enabled:
  - activity: 2.2.1
  - calendar: 1.3.2
  - comments: 0.2
  - contacts: 1.3.1.0
  - dav: 0.1.6
  - direct_menu: 0.8.1
  - documents: 0.12.1
  - federatedfilesharing: 0.1.0
  - federation: 0.0.4
  - files: 1.4.4
  - files_external: 0.5.2
  - files_locking: true
  - files_pdfviewer: 0.8.1
  - files_share_qr: 0.1
  - files_sharing: 0.9.1
  - files_texteditor: 2.1
  - files_trashbin: 0.8.0
  - files_versions: 1.2.0
  - files_videoplayer: 0.9.8
  - files_videoviewer: 0.1.3
  - firstrunwizard: 1.1
  - gallery: 14.5.0
  - logreader: 1.1.5
  - notifications: 0.2.3
  - ownbackup: 0.3.8
  - provisioning_api: 0.3.0
  - systemtags: 0.2
  - templateeditor: 0.1
  - updatenotification: 0.1.0
Disabled:
  - encryption
  - external
  - ocusagecharts
  - storagecharts2
  - storagecharts2_new
  - updater
  - user_external
  - user_ldap
  - user_otp
  - user_webdavauth

lock · 2019-08-05T00:02:48Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

karlitschek reviewed Sep 9, 2015
View reviewed changes

MorrisJobke added the 2 - Developing label Sep 9, 2015

DeepDiver1975 added this to the 9.0-next milestone Sep 15, 2015

zyrill mentioned this pull request Sep 16, 2015

ownCloud 8.1: php-error Array to string conversion #17468

Closed

Berndinox mentioned this pull request Sep 17, 2015

OC8.1 - Openstack Swift remove does not work #19125

Closed

MorrisJobke reviewed Sep 23, 2015
View reviewed changes

MorrisJobke added the Type:Bug label Sep 23, 2015

MorrisJobke added 3 - To Review and removed 2 - Developing labels Oct 6, 2015

zyrill closed this Oct 6, 2015

MorrisJobke reopened this Oct 6, 2015

Fixes: Error PHP Array to string conversion at /share/MD0_DATA/Web/o…

f8580b5

…wncloud/lib/private/template/functions.php#36 See #17468 for bug description. Incorporated changes proposed by @MorrisJobke and by @szepeviktor, see #18921

MorrisJobke mentioned this pull request Oct 6, 2015

[Jenkins] Fixes: Error PHP Array to string conversion at /share/MD0_DATA/Web/o… #19612

Closed

VicDeo mentioned this pull request Oct 13, 2015

[OC 8.0.3] still get Array to string conversion at /owncloud/lib/private/l10n/string.php#75 owncloud/updater#133

Closed

PVince81 added the comp:core label Nov 17, 2015

MorrisJobke mentioned this pull request Nov 23, 2015

p() supports string as argument #20679

Merged

MorrisJobke closed this Nov 23, 2015

bcutter mentioned this pull request Aug 15, 2016

Code integrity check after changing maximum upload size via GUI #23321

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019

Fixes: Error PHP Array to string conversion at .../oc/lib/private/template/functions.php#36 #18921

Fixes: Error PHP Array to string conversion at .../oc/lib/private/template/functions.php#36 #18921

Conversation

zyrill commented Sep 9, 2015

scrutinizer-notifier commented Sep 9, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zyrill commented Sep 15, 2015

szepeviktor commented Sep 16, 2015

szepeviktor commented Sep 16, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

widac commented Sep 28, 2015

ronniehd commented Oct 5, 2015

zyrill commented Oct 6, 2015

MorrisJobke commented Oct 6, 2015

szepeviktor commented Oct 6, 2015

szepeviktor commented Oct 6, 2015

zyrill commented Oct 6, 2015

MorrisJobke commented Oct 6, 2015

PVince81 commented Oct 20, 2015

LukasReschke commented Oct 25, 2015

mmattel commented Oct 27, 2015

EtienneBruines commented Oct 27, 2015

MorrisJobke commented Oct 27, 2015

MorrisJobke commented Oct 27, 2015

mmattel commented Oct 27, 2015

nickvergessen commented Oct 27, 2015

szepeviktor commented Oct 27, 2015

MorrisJobke commented Oct 27, 2015

MorrisJobke commented Oct 27, 2015

zyrill commented Oct 27, 2015

MorrisJobke commented Oct 27, 2015

PVince81 commented Nov 17, 2015

MorrisJobke commented Nov 23, 2015

nickvergessen commented Nov 23, 2015

MorrisJobke commented Nov 23, 2015

MorrisJobke commented Nov 23, 2015

bcutter commented Aug 15, 2016 • edited Loading

lock bot commented Aug 5, 2019

bcutter commented Aug 15, 2016 •

edited

Loading