Use custom attribute instead of the div identifier

[LukasReschke]

Otherwise problems arrive when a username contains characters such as an @

Fixes https://github.com/owncloud/user_shibboleth/issues/38

@nickvergessen @DeepDiver1975

[nickvergessen]

Works here, can we add a test for this somehow, in the test file you edited?

[LukasReschke]

Works here, can we add a test for this somehow, in the test file you edited?

There is a test?

[LukasReschke]

Ah you mean with @ … well we can do but it won't help much :P

[LukasReschke]

(as the only dangerous characters here are " and ' )

[nickvergessen]

hmm yeah I mean like sharing the item with a user and then check whether it works, just to make sure that if someone changes it back, it still works, or at least he sees, oh something special about @?

Anyway, 👍 from me

[DeepDiver1975]

tested 👍

[DeepDiver1975]

I question where stuff like that can explode as well ....

[DeepDiver1975]

backport to stable8 please - THX

[karlitschek]

Yes. Definitely backport

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10073/
Test PASSed.

[LukasReschke]

I'd love to backport. However I'm pretty sure that is a feature available in master only? 😕

[LukasReschke]

{"installed":true,"maintenance":false,"version":"8.0.0.9","versionstring":"8.0","edition":"Enterprise"}

@karlitschek Maybe we should change the version in master again just to see directly if it is master or stable8?

[scrutinizer-notifier]

The inspection completed: No new issues

[PVince81]

I believe this is master only, 8.1.

Isn't it, @rullzer ?

[rullzer]

Yep only in 8.1 as far as I know