Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when invalid user was passed #12290

Merged
merged 1 commit into from
Nov 19, 2014

Conversation

PVince81
Copy link
Contributor

Sometimes there are bugs that cause setupFS() to be called for
non-existing users. Instead of failing hard and breaking the instance,
this fix simply logs a warning.

Supersedes #12175 due to Jenkins' inability to properly check out code from branches where code was force pushed

Sometimes there are bugs that cause setupFS() to be called for
non-existing users. Instead of failing hard and breaking the instance,
this fix simply logs a warning.
@ghost
Copy link

ghost commented Nov 19, 2014

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/2826/
🚀 Test PASSed. 🚀

@LukasReschke
Copy link
Member

Already reviewed at the other PR. - Let's merge.

LukasReschke added a commit that referenced this pull request Nov 19, 2014
Show warning when invalid user was passed
@LukasReschke LukasReschke merged commit 284ba5b into master Nov 19, 2014
@LukasReschke LukasReschke deleted the ext-preventbreakageduetobugs2 branch November 19, 2014 13:27
@craigpg craigpg added this to the 8.0-current milestone Nov 21, 2014
@utack
Copy link

utack commented Nov 25, 2014

I applied the patch manually.
Do I need to revert this before upgrading to the next OC version or will the file be overwritten no matter the content?

@MorrisJobke MorrisJobke mentioned this pull request Mar 19, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants