Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symfony events for more login hooks #31956

Closed
sharidas opened this issue Jun 29, 2018 · 6 comments
Closed

Add symfony events for more login hooks #31956

sharidas opened this issue Jun 29, 2018 · 6 comments
Assignees
Milestone

Comments

@sharidas
Copy link
Contributor

As of now the symfony login events are present in

There are places like encryption or may be more where we need to have similar events to be added.

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributors most likely able to help are @PVince81, and @butonic.

Possibly related issues are #31467 (Symfony events added for login failed and public link accessed), #30268 ([WIP] Adding new symfony events to replace old hooks), #31465 (Missing symfony event for failed login attempt), #30996 (Throw symfony events on group actions), and #29174 (Provide symfony event dispatcher events for all older hook types).

@PVince81
Copy link
Contributor

PVince81 commented Jul 2, 2018

as requested by @DeepDiver1975

as discussed, to be worked on in this sprint

@PVince81
Copy link
Contributor

PVince81 commented Aug 6, 2018

Estimate: 0.5md

@sharidas
Copy link
Contributor Author

The symfony events added for login were for the following methods in https://github.com/owncloud/core/blob/master/lib/private/User/Session.php:

  • login() covers the symfony events for loginWithToken() and loginWithPassword().
  • loginWithPassword() has before and after symfony events.
  • loginWithToken() has before and after symfony events.
  • loginWithApache() has before and after symfony events.
  • loginUser() has before and after symfony events.

For encryption it is taken care by the post_login event, which happens via postLogin event. Meaning we don't have to do anything there.

I think we have covered the login hooks, due to which this issue was raised.

@PVince81
Copy link
Contributor

please close if there is nothing left to do

@sharidas
Copy link
Contributor Author

Closing this PR as the login hooks were added mentioned as per #31956 (comment)

@PVince81 PVince81 modified the milestones: development, QA Jan 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants