Merge pull request #32535 from owncloud/remove-autocomplete-from-pass…

…word-fields AutoComplete off for password fields
owncloud · Aug 31, 2018 · e911f01 · e911f01
2 parents c3d666b + 16b3a09
commit e911f01
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 11 deletions.
diff --git a/apps/files_external/js/settings.js b/apps/files_external/js/settings.js
@@ -1076,7 +1076,7 @@ MountConfigListView.prototype = _.extend({
 
 		var trimmedPlaceholder = placeholder.value;
 		if (placeholder.type === MountConfigListView.ParameterTypes.PASSWORD) {
-			newElement = $('<input type="password" class="'+classes.join(' ')+'" data-parameter="'+parameter+'" placeholder="'+ trimmedPlaceholder+'" />');
+			newElement = $('<input type="password" class="'+classes.join(' ')+'" data-parameter="'+parameter+'" placeholder="'+ trimmedPlaceholder+'" autocomplete="off" />');
 		} else if (placeholder.type === MountConfigListView.ParameterTypes.BOOLEAN) {
 			var checkboxId = _.uniqueId('checkbox_');
 			newElement = $('<div><label><input type="checkbox" id="'+checkboxId+'" class="'+classes.join(' ')+'" data-parameter="'+parameter+'" />'+ trimmedPlaceholder+'</label></div>');

diff --git a/apps/files_external/js/statusmanager.js b/apps/files_external/js/statusmanager.js
@@ -385,7 +385,7 @@ OCA.External.StatusManager = {
 		'<div>{{credentials_text}}</div>' +
 		'<form>' +
 		'<input type="text" name="username" placeholder="{{placeholder_username}}"/>' +
-		'<input type="password" name="password" placeholder="{{placeholder_password}}"/>' +
+		'<input type="password" name="password" placeholder="{{placeholder_password}}" autocomplete="off"/>' +
 		'</form>' +
 		'</div></div>',
 

diff --git a/apps/files_sharing/templates/authenticate.php b/apps/files_sharing/templates/authenticate.php
@@ -15,12 +15,8 @@
 		<p>
 			<label for="password" class="infield"><?php p($l->t('Password')); ?></label>
 			<input type="hidden" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
-			<input type="password" name="password" id="password"
-				placeholder="<?php p($l->t('Password')); ?>" value=""
-				autocomplete="off" autocapitalize="off" autocorrect="off"
-				autofocus />
-			<input type="submit" id="password-submit" 
-				class="svg icon-confirm input-button-inline" value="" disabled="disabled" />
+			<input type="password" name="password" id="password" placeholder="<?php p($l->t('Password')); ?>" value="" autocomplete="off" autocapitalize="off" autocorrect="off" autofocus />
+			<input type="submit" id="password-submit"  class="svg icon-confirm input-button-inline" value="" disabled="disabled" />
 		</p>
 	</fieldset>
 </form>
diff --git a/core/js/sharedialoglinkshareview.js b/core/js/sharedialoglinkshareview.js
@@ -41,7 +41,7 @@
 			'{{/if}}' +
 			'<div id="linkPass-{{cid}}" class="public-link-modal--item linkPass">' +
 				'<label class="public-link-modal--label" for="linkPassText-{{cid}}">{{passwordLabel}}</label>' +
-				'<input class="public-link-modal--input linkPassText" id="linkPassText-{{cid}}" type="password" placeholder="{{passwordPlaceholder}}" />' +
+				'<input class="public-link-modal--input linkPassText" id="linkPassText-{{cid}}" type="password" autocomplete="off" placeholder="{{passwordPlaceholder}}" />' +
 				'<span class="error-message hidden"></span>' +
 			'</div>' +
 			'<div class="expirationDateContainer"></div>' +

diff --git a/core/templates/login.php b/core/templates/login.php
@@ -56,7 +56,7 @@
 			<input type="password" name="password" id="password" value=""
 				placeholder="<?php p($l->t('Password')); ?>"
 				<?php p($_['user_autofocus'] ? '' : 'autofocus'); ?>
-				autocomplete="on" autocapitalize="off" autocorrect="off" required>
+				autocomplete="off" autocapitalize="off" autocorrect="off" required>
 			<label for="password" class="infield"><?php p($l->t('Password')); ?></label>
 			<input type="submit" id="submit" class="login primary icon-confirm" title="<?php p($l->t('Log in')); ?>" value="" disabled="disabled"/>
 		</p>

diff --git a/core/templates/lostpassword/resetpassword.php b/core/templates/lostpassword/resetpassword.php
@@ -30,7 +30,7 @@
 	<fieldset>
 		<p>
 			<label for="password" class="infield"><?php p($l->t('New password')); ?></label>
-			<input type="password" name="password" id="password" value="" placeholder="<?php p($l->t('New Password')); ?>" required autofocus />
+			<input type="password" name="password" id="password" value="" placeholder="<?php p($l->t('New Password')); ?>" autocomplete="off" required autofocus />
 		</p>
 		<input type="submit" id="submit" value="<?php p($l->t('Reset password')); ?>" />
 		<p class="text-center">