Alter oc_jobs before enabing market app

owncloud · Sep 4, 2018 · daff39f · daff39f
1 parent 172f3cd
commit daff39f
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 6 deletions.
diff --git a/core/Migrations/Version20170101010030.php b/core/Migrations/Version20170101010030.php
@@ -0,0 +1,51 @@
+<?php
+
+namespace OC\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\DBAL\Types\Type;
+use OCP\Migration\ISchemaMigration;
+
+/**
+ * DB update for oc_jobs table
+ * it is intentionally duplicates 20170213215145 and a part of 20170101215145
+ * to allow seamless market app installation
+ */
+class Version20170101010030 implements ISchemaMigration {
+	public function changeSchema(Schema $schema, array $options) {
+		$prefix = $options['tablePrefix'];
+		if ($schema->hasTable("${prefix}jobs")) {
+			$jobsTable = $schema->getTable("${prefix}jobs");
+
+			if (!$jobsTable->hasColumn('last_checked')) {
+				$jobsTable->addColumn(
+					'last_checked',
+					Type::INTEGER,
+					[
+						'default' => 0,
+						'notnull' => false
+					]
+				);
+			}
+
+			if (!$jobsTable->hasColumn('reserved_at')) {
+				$jobsTable->addColumn(
+					'reserved_at',
+					Type::INTEGER,
+					[
+						'default' => 0,
+						'notnull' => false
+					]
+				);
+			}
+
+			if (!$jobsTable->hasColumn('execution_duration')) {
+				$jobsTable->addColumn('execution_duration', Type::INTEGER, [
+					'notnull' => true,
+					'length' => 5,
+					'default' => -1,
+				]);
+			}
+		}
+	}
+}
diff --git a/core/Migrations/Version20170213215145.php b/core/Migrations/Version20170213215145.php
@@ -13,12 +13,13 @@ public function changeSchema(Schema $schema, array $options) {
 		$prefix = $options['tablePrefix'];
 		if ($schema->hasTable("${prefix}jobs")) {
 			$table = $schema->getTable("${prefix}jobs");
-
-			$table->addColumn('execution_duration', 'integer', [
-				'notnull' => true,
-				'length' => 5,
-				'default' => -1,
-			]);
+			if (!$table->hasColumn('execution_duration')) {
+				$table->addColumn('execution_duration', 'integer', [
+					'notnull' => true,
+					'length' => 5,
+					'default' => -1,
+				]);
+			}
 		}
 	}
 }
diff --git a/lib/private/Repair/Apps.php b/lib/private/Repair/Apps.php
@@ -21,6 +21,7 @@
 
 namespace OC\Repair;
 
+use OC\DB\MigrationService;
 use OC\RepairException;
 use OC_App;
 use OCP\App\AppAlreadyInstalledException;
@@ -326,6 +327,10 @@ private function fixMarketAppState(IOutput $output) {
 		// Then we need to enable the market app to support app updates / downloads during upgrade
 		$output->info('Enabling market app to assist with update');
 		try {
+			// Prepare oc_jobs for older ownCloud version fixes https://github.com/owncloud/update-testing/issues/5
+			$ms = new MigrationService('core', \OC::$server->getDatabaseConnection(), $output);
+			$ms->executeStep('20170101010030');
+
 			$this->appManager->enableApp('market');
 			return true;
 		} catch (\Exception $ex) {