Merge pull request #27885 from owncloud/allow-multiple-settings-panel…

…s-per-app Allow app to register multiple settings panels of same type
owncloud · May 15, 2017 · aaba0b5 · aaba0b5
2 parents 81d2f35 + fa2900a
commit aaba0b5
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 2 deletions.
diff --git a/lib/private/Settings/SettingsManager.php b/lib/private/Settings/SettingsManager.php
@@ -315,10 +315,12 @@ protected function findRegisteredPanels($type) {
 		$panels = [];
 		foreach($this->appManager->getEnabledAppsForUser($this->userSession->getUser()) as $app) {
 			if(isset($this->appManager->getAppInfo($app)['settings'])) {
-				foreach($this->appManager->getAppInfo($app)['settings'] as $t => $panel) {
+				foreach($this->appManager->getAppInfo($app)['settings'] as $t => $detected) {
 					if($t === $type)
 					{
-						$panels[] = (string) $panel;
+						// Allow app to register multiple panels of the same type
+						$detected = is_array($detected) ? $detected : [$detected];
+						$panels = array_merge($panels, $detected);
 					}
 				}
 			}

diff --git a/tests/lib/Settings/ManagerTest.php b/tests/lib/Settings/ManagerTest.php
@@ -90,6 +90,52 @@ public function testGetPanelsList() {
 		$this->assertContains('OC\Settings\Panels\Personal\Profile', $list);
 	}
 
+	public function testFindRegisteredPanelsAdmin() {
+		// Return a mock user
+		$user = $this->getMockBuilder('\OCP\IUser')->getMock();
+		$this->userSession->expects($this->any())->method('getUser')->willReturn($user);
+		// Return encryption as example app with
+		$this->appManager->expects($this->exactly(1))->method('getEnabledAppsForUser')->with($user)->willReturn(['encryption']);
+		$settingsInfo = [
+			'settings' =>
+				['admin' => 'OCA\Encryption\TestPanel']
+		];
+		$this->appManager->expects($this->exactly(2))->method('getAppInfo')->with('encryption')->willReturn($settingsInfo);
+		$panels = $this->invokePrivate($this->settingsManager, 'findRegisteredPanels', ['admin']);
+		$this->assertCount(1, $panels);
+	}
+
+	public function testFindRegisteredPanelsPersonal() {
+		// Return a mock user
+		$user = $this->getMockBuilder('\OCP\IUser')->getMock();
+		$this->userSession->expects($this->any())->method('getUser')->willReturn($user);
+		// Return encryption as example app with
+		$this->appManager->expects($this->exactly(1))->method('getEnabledAppsForUser')->with($user)->willReturn(['encryption']);
+		$settingsInfo = [
+			'settings' =>
+				['personal' => 'OCA\Encryption\TestPanel']
+		];
+		$this->appManager->expects($this->exactly(2))->method('getAppInfo')->with('encryption')->willReturn($settingsInfo);
+		$panels = $this->invokePrivate($this->settingsManager, 'findRegisteredPanels', ['personal']);
+		$this->assertCount(1, $panels);
+		$this->assertEquals('OCA\Encryption\TestPanel', array_shift($panels));
+	}
+
+	public function testFindRegisteredPanelsPersonalMultiple() {
+		// Return a mock user
+		$user = $this->getMockBuilder('\OCP\IUser')->getMock();
+		$this->userSession->expects($this->any())->method('getUser')->willReturn($user);
+		// Return encryption as example app with
+		$this->appManager->expects($this->exactly(1))->method('getEnabledAppsForUser')->with($user)->willReturn(['encryption']);
+		$settingsInfo = [
+			'settings' =>
+				['personal' => ['OCA\Encryption\TestPanel', 'OCA\Encryption\TestPanel2']]
+		];
+		$this->appManager->expects($this->exactly(2))->method('getAppInfo')->with('encryption')->willReturn($settingsInfo);
+		$panels = $this->invokePrivate($this->settingsManager, 'findRegisteredPanels', ['personal']);
+		$this->assertCount(2, $panels);
+	}
+
 	public function testLoadPersonalPanels() {
 		$user = $this->getMockBuilder('\OCP\IUser')->getMock();
 		$this->userSession->expects($this->any())->method('getUser')->willReturn($user);