Merge pull request #28213 from owncloud/improve-query-performance

use efficient startsWith implementation, don't check if key exists twice
owncloud · Jun 29, 2017 · 68fdcb3 · 68fdcb3
2 parents 093b82e + 3a057be
commit 68fdcb3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/private/AppFramework/Utility/SimpleContainer.php b/lib/private/AppFramework/Utility/SimpleContainer.php
@@ -107,9 +107,9 @@ public function resolve($name) {
 	 */
 	public function query($name) {
 		$name = $this->sanitizeName($name);
-		if ($this->offsetExists($name)) {
+		try {
 			return $this->offsetGet($name);
-		} else {
+		} catch (\InvalidArgumentException $ex) {
 			$object = $this->resolve($name);
 			$this->registerService($name, function () use ($object) {
 				return $object;

diff --git a/lib/private/ServerContainer.php b/lib/private/ServerContainer.php
@@ -73,7 +73,7 @@ public function query($name) {
 
 		// In case the service starts with OCA\ we try to find the service in
 		// the apps container first.
-		if (strpos($name, 'OCA\\') === 0 && substr_count($name, '\\') >= 2) {
+		if (strrpos($name, 'OCA\\', -strlen($name)) !== false && substr_count($name, '\\') >= 2) {
 			$segments = explode('\\', $name);
 			$appContainer = $this->getAppContainer(strtolower($segments[1]));
 			try {