Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Fix fast share creation with enforced expiry and 10.2.0 #7249

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented Jun 17, 2019

Fixes the "Copy public link to clipboard" context menu action for newer
servers.

Previously the server would fill the expiration date for us, since
version 10.2.0 it reports an error. To workaround that the action now
always sends an expiration date if default expiration is enabled in
the settings.

For #7245

@ckamm ckamm added this to the 2.6.0 milestone Jun 17, 2019
@ckamm ckamm requested a review from ogoffart June 17, 2019 07:23
@ckamm ckamm self-assigned this Jun 17, 2019
Fixes the "Copy public link to clipboard" context menu action for newer
servers.

Previously the server would fill the expiration date for us, since
version 10.2.0 it reports an error. To workaround that the action now
always sends an expiration date if default expiration is enabled in
the settings.

For #7245
@ckamm ckamm force-pushed the 7245-linkshare-autocreate-with-expiry branch from 01d5bd9 to 60fa7ea Compare June 17, 2019 07:24
Copy link
Contributor

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this shows a bug on the server, that change of behavior will break with old client and this isn't good.
Is there an issue open on the server for this?

@ckamm
Copy link
Contributor Author

ckamm commented Jun 18, 2019

@ogoffart Yeah: owncloud/core#35564

@ckamm ckamm merged commit c36495d into 2.6 Jun 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the 7245-linkshare-autocreate-with-expiry branch June 18, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants