Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exdate #920

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Exdate #920

merged 1 commit into from
Jun 12, 2018

Conversation

Julian1998
Copy link
Contributor

@Julian1998 Julian1998 commented Jun 9, 2018

Instructions:

  • create a new event
  • click on more...
  • add some recurrence features
  • click on create
  • now delete the event or just some occurrences

Possible scenarios:

  • Deleting just occurrences in popover view
  • Deleting just occurrences in sidebar view
  • Deleting the whole event in popover view
  • Deleting the whole event in sidebar view

All scenarios work fine in Chrome and Firefox

@coveralls
Copy link

coveralls commented Jun 9, 2018

Coverage Status

Coverage decreased (-0.3%) to 53.971% when pulling 78ef28c on exdate into 8494037 on master.

@codecov-io
Copy link

codecov-io commented Jun 11, 2018

Codecov Report

Merging #920 into master will decrease coverage by 0.28%.
The diff coverage is 6.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
- Coverage   58.09%   57.81%   -0.29%     
==========================================
  Files          66       66              
  Lines        3303     3321      +18     
==========================================
+ Hits         1919     1920       +1     
- Misses       1384     1401      +17
Impacted Files Coverage Δ
js/app/controllers/recurrencecontroller.js 1.72% <0%> (ø) ⬆️
js/app/controllers/editorcontroller.js 0.72% <0%> (-0.03%) ⬇️
js/app/models/simpleEventModel.js 87.95% <50%> (ø) ⬆️
js/app/controllers/calcontroller.js 3.89% <7.14%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8494037...78ef28c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants