Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] "New folder" option in folder picker with incorrect dictation #4475

Conversation

Aitorbp
Copy link
Collaborator

@Aitorbp Aitorbp commented Sep 23, 2024

Related Issues

App: #4473

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 24, 2024

The new message was checked in the following scenarios:

  • Copy
  • Move
  • Share form 3rd party app
  • Auto uploads target folder

from my side is OK

@jesmrec jesmrec force-pushed the feature/new_folder_option_in_folder_picker_with_incorrect_dictation branch from da366da to ca7eca3 Compare September 24, 2024 10:35
@jesmrec jesmrec merged commit 9ce4b7c into master Sep 24, 2024
7 checks passed
@jesmrec jesmrec deleted the feature/new_folder_option_in_folder_picker_with_incorrect_dictation branch September 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y] "New folder" option in folder picker with incorrect dictation
3 participants